[S] Change in coreboot[master]: mb/google/nissa/var/pujjo: Tune timing on SD device RTD3 - coreboot-gerrit

15 Nov 2022


      Attention is currently required from: Tarun Tuli, Kangheui Won, Shou-Chieh Hsu, Leo Chou.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69679 )
Change subject: mb/google/nissa/var/pujjo: Tune timing on SD device RTD3
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brya/variants/pujjo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/69679/comment/653206f7_973e8241 
PS1, Line 546: 50
Why 50 ms? The datasheet only says min 10 us.
Also do you need reset_off_delay_ms as well to meet TPERST-OFF?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/69679
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1ea77ec8381000249229653f1c0b9044bdf7866d
Gerrit-Change-Number: 69679
Gerrit-PatchSet: 1
Gerrit-Owner: Leo Chou leo.chou@lcfc.corp-partner.google.com
Gerrit-Reviewer: Kangheui Won khwon@chromium.org
Gerrit-Reviewer: Reka Norman rekanorman@chromium.org
Gerrit-Reviewer: Shou-Chieh Hsu shouchieh@google.com
Gerrit-Reviewer: Tarun Tuli taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Joey Peng joey.peng@lcfc.corp-partner.google.com
Gerrit-CC: Jynn Chen jynn.chen@lcfc.corp-partner.google.com
Gerrit-CC: Kevin3 Yang Kevin3.Yang@lcfuturecenter.com
Gerrit-CC: Melo Chuang melo.chuang@lcfc.corp-partner.google.com
Gerrit-CC: Stanley Wu stanley1.wu@lcfc.corp-partner.google.com
Gerrit-Attention: Tarun Tuli taruntuli@google.com
Gerrit-Attention: Kangheui Won khwon@chromium.org
Gerrit-Attention: Shou-Chieh Hsu shouchieh@google.com
Gerrit-Attention: Leo Chou leo.chou@lcfc.corp-partner.google.com
Gerrit-Comment-Date: Wed, 16 Nov 2022 03:11:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment