Attention is currently required from: Alper Nebi Yasak, Martin L Roth, Paul Menzel.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80365?usp=email )
Change subject: mb/qemu/fw_cfg: Support using DMA to select fw_cfg file
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80365/comment/addaedf4_8bf2545a :
PS1, Line 11: "file"s
Plural. […]
quotes are fine IMO, but around the whole word ("files"). breaking it up as it is now is both hard to read and confusing
https://review.coreboot.org/c/coreboot/+/80365/comment/39eb6299_202c5b45 :
PS1, Line 15: to other architectures
It's used for qemu-i440fx and qemu-q35 right now, but I'm trying to move the relevant files to drive […]
SGTM
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80365?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I46f9915e6df04d371c7084815f16034c7e9879d4
Gerrit-Change-Number: 80365
Gerrit-PatchSet: 2
Gerrit-Owner: Alper Nebi Yasak
alpernebiyasak@gmail.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Alper Nebi Yasak
alpernebiyasak@gmail.com
Gerrit-Comment-Date: Wed, 28 Feb 2024 20:47:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth
gaumless@gmail.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Alper Nebi Yasak
alpernebiyasak@gmail.com
Gerrit-MessageType: comment