Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42065 )
Change subject: soc/amd/picasso: Remove unnecessary includes from pmutil.c ......................................................................
soc/amd/picasso: Remove unnecessary includes from pmutil.c
While working on psp_verstage, I noticed that this file had a number of unnecessary includes. Remove them.
BUG=b:158124527 TEST=Build & boot psp_verstage on trembyle
Signed-off-by: Martin Roth martin@coreboot.org Change-Id: I32188e2dda39ece9dc98d0344824d997a2e80303 --- M src/soc/amd/picasso/pmutil.c 1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/42065/1
diff --git a/src/soc/amd/picasso/pmutil.c b/src/soc/amd/picasso/pmutil.c index a2ad2db..5baf923 100644 --- a/src/soc/amd/picasso/pmutil.c +++ b/src/soc/amd/picasso/pmutil.c @@ -1,9 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <acpi/acpi.h> -#include <soc/southbridge.h> -#include <amdblocks/acpimmio.h> -#include <security/vboot/vboot_common.h> #include <security/vboot/vbnv.h> #include <pc80/mc146818rtc.h>
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42065 )
Change subject: soc/amd/picasso: Remove unnecessary includes from pmutil.c ......................................................................
Patch Set 3: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42065 )
Change subject: soc/amd/picasso: Remove unnecessary includes from pmutil.c ......................................................................
soc/amd/picasso: Remove unnecessary includes from pmutil.c
While working on psp_verstage, I noticed that this file had a number of unnecessary includes. Remove them.
BUG=b:158124527 TEST=Build & boot psp_verstage on trembyle
Signed-off-by: Martin Roth martin@coreboot.org Change-Id: I32188e2dda39ece9dc98d0344824d997a2e80303 Reviewed-on: https://review.coreboot.org/c/coreboot/+/42065 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Raul Rangel rrangel@chromium.org --- M src/soc/amd/picasso/pmutil.c 1 file changed, 0 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Raul Rangel: Looks good to me, approved
diff --git a/src/soc/amd/picasso/pmutil.c b/src/soc/amd/picasso/pmutil.c index a2ad2db..5baf923 100644 --- a/src/soc/amd/picasso/pmutil.c +++ b/src/soc/amd/picasso/pmutil.c @@ -1,9 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <acpi/acpi.h> -#include <soc/southbridge.h> -#include <amdblocks/acpimmio.h> -#include <security/vboot/vboot_common.h> #include <security/vboot/vbnv.h> #include <pc80/mc146818rtc.h>
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42065 )
Change subject: soc/amd/picasso: Remove unnecessary includes from pmutil.c ......................................................................
Patch Set 4:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/5200 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/5199 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/5198 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/5197
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Felix Held (Code Review)
-
Martin Roth (Code Review)
-
Raul Rangel (Code Review)