Attention is currently required from: Jérémy Compostella, Pranava Y N, Subrata Banik.
Anil Kumar K has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/84407?usp=email )
Change subject: mb/google/fatcat: Add override tree ......................................................................
Patch Set 8:
(6 comments)
File src/mainboard/google/fatcat/variants/fatcat/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/84407/comment/5921c4d0_218dbb66?usp... : PS1, Line 63: DDI_ENABLE_DDC
Is this required to be enabled?
not needed for EDP
https://review.coreboot.org/c/coreboot/+/84407/comment/61b299de_7def0d9e?usp... : PS1, Line 223: use usb2_port1 as usb2_port : use tcss_usb3_port0 as usb3_port : device generic 0 alias conn0 on end : end : chip drivers/intel/pmc_mux/conn : use usb2_port2 as usb2_port : use tcss_usb3_port1 as usb3_port : device generic 1 alias conn1 on end : end : chip drivers/intel/pmc_mux/conn : use usb2_port3 as usb2_port : use tcss_usb3_port2 as usb3_port : device generic 2 alias conn2 on end : end : chip drivers/intel/pmc_mux/conn : use usb2_port4 as usb2_port : use tcss_usb3_port3 as usb3_port : device generic 3 alias conn3 on end : end : end
I also don't believe we need PMC MUX when we are planning to use PDC<->PMC communication in PTL
Acknowledged
https://review.coreboot.org/c/coreboot/+/84407/comment/f30c2255_bbe272d1?usp... : PS1, Line 335: device ref xhci on
NOT IMPORTANT: It would be better to put this block right after tcss_dma
Acknowledged
https://review.coreboot.org/c/coreboot/+/84407/comment/5cb74a70_7defdd21?usp... : PS1, Line 339: register "desc" = ""USB2 Type-A Port 1"" : register "type" = "UPC_TYPE_A" : register "group" = "ACPI_PLD_GROUP(1, 1)" : device ref usb2_port1 on end : end : chip drivers/usb/acpi : register "desc" = ""USB2 Type-A Port 2"" : register "type" = "UPC_TYPE_A" : register "group" = "ACPI_PLD_GROUP(2, 1)" : device ref usb2_port2 on end : end : chip drivers/usb/acpi : register "desc" = ""USB2 Type-A Port 3"" : register "type" = "UPC_TYPE_A" : register "group" = "ACPI_PLD_GROUP(3, 1)" : device ref usb2_port3 on end : end : chip drivers/usb/acpi : register "desc" = ""USB2 Type-A Port 4"" : register "type" = "UPC_TYPE_A" : register "group" = "ACPI_PLD_GROUP(4, 1)" : device ref usb2_port4 on end : end
Ports 1-4 are used for Type-C right? Please change these to map correctly.
Acknowledged
https://review.coreboot.org/c/coreboot/+/84407/comment/0acdf483_cef30bcb?usp... : PS1, Line 363: Port 5"
Port 1
Acknowledged
https://review.coreboot.org/c/coreboot/+/84407/comment/9e6e56e5_9339a383?usp... : PS1, Line 369: Port 6"
Port 2
Acknowledged
-
Anil Kumar K (Code Review)