[M] Change in coreboot[master]: soc/intel/xeon_sp: Don't sort struct device cpus for numa

[Arthur Heymans (Code Review)]

Attention is currently required from: Lance Zhao, Arthur Heymans, Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Tim Wawrzynczak, Christian Walter, Angel Pons, Shuming Chu (Shuming), TangYiwei.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68912 )

Change subject: soc/intel/xeon_sp: Don't sort struct device cpus for numa
......................................................................

Patch Set 6:

(2 comments)

File src/soc/intel/xeon_sp/nb_acpi.c:

https://review.coreboot.org/c/coreboot/+/68912/comment/b97fe6ea_1c6f9a88 
PS3, Line 29: /* First all regular cpus, then all the threads */
            : 	for (cpu = all_devices; cpu; cpu = cpu->next) {
            : 		if (!is_enabled_cpu(cpu))
            : 			continue;
            : 		if (num_cpus >= ARRAY_SIZE(apic_ids))
            : 			break;
            : 		/* Is this a thread? */
            : 		if (cpu->path.apic.apic_id & 1)
            : 			continue;
            : 		apic_ids[num_cpus++] = cpu->path.apic.apic_id;
            : 	}
            : 	const uint32_t num_of_cores = num_cpus;
            : 	if (num_cpus > 1)
            : 		bubblesort(&apic_ids[0], num_of_cores, NUM_ASCENDING);
> > Maybe rewrite this as a loop? […]

Done

https://review.coreboot.org/c/coreboot/+/68912/comment/83370364_256cd0cd 
PS3, Line 54: 	if (num_cpus > 1)
> > What's the purpose of this check? Did you mean to check if `num_cpus - num_of_cores > 1` instead?  […]

Done