Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36709 )
Change subject: mb/asus/p5ql-em: Fix S3 resume ......................................................................
mb/asus/p5ql-em: Fix S3 resume
The superio VSBGATE# functionality needs to be enabled for ram to be powered during S3.
Change-Id: I7b827e025de7d5b53c587872238a411fc9c2e762 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/mainboard/asus/p5ql-em/devicetree.cb 1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/36709/1
diff --git a/src/mainboard/asus/p5ql-em/devicetree.cb b/src/mainboard/asus/p5ql-em/devicetree.cb index 8b5215e..1653403 100644 --- a/src/mainboard/asus/p5ql-em/devicetree.cb +++ b/src/mainboard/asus/p5ql-em/devicetree.cb @@ -138,7 +138,9 @@ irq 0xe0 = 0xdf irq 0xf3 = 0x09 # RSVD SUSLED settings end - device pnp 2e.a off end # ACPI + device pnp 2e.a on # ACPI + irq 0xe4 = 0x10 # VSBGATE# to power dram during S3 + end device pnp 2e.b on # HWM, front panel LED io 0x60 = 0x290 irq 0x70 = 0
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36709 )
Change subject: mb/asus/p5ql-em: Fix S3 resume ......................................................................
Patch Set 1: Code-Review+2
*grumbles at the SuperIO*
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36709 )
Change subject: mb/asus/p5ql-em: Fix S3 resume ......................................................................
Patch Set 1: Code-Review+2
Arthur Heymans has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36709 )
Change subject: mb/asus/p5ql-em: Fix S3 resume ......................................................................
mb/asus/p5ql-em: Fix S3 resume
The superio VSBGATE# functionality needs to be enabled for ram to be powered during S3.
Change-Id: I7b827e025de7d5b53c587872238a411fc9c2e762 Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/36709 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/asus/p5ql-em/devicetree.cb 1 file changed, 3 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/asus/p5ql-em/devicetree.cb b/src/mainboard/asus/p5ql-em/devicetree.cb index 8b5215e..1653403 100644 --- a/src/mainboard/asus/p5ql-em/devicetree.cb +++ b/src/mainboard/asus/p5ql-em/devicetree.cb @@ -138,7 +138,9 @@ irq 0xe0 = 0xdf irq 0xf3 = 0x09 # RSVD SUSLED settings end - device pnp 2e.a off end # ACPI + device pnp 2e.a on # ACPI + irq 0xe4 = 0x10 # VSBGATE# to power dram during S3 + end device pnp 2e.b on # HWM, front panel LED io 0x60 = 0x290 irq 0x70 = 0