Attention is currently required from: zanxi chen. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57642 )
Change subject: mb/google/trogdor: Add mipi panel for wormdingler ......................................................................
Patch Set 3:
(25 comments)
File src/drivers/mipi/panel-BOE_TV110C9M_LL0.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128121): https://review.coreboot.org/c/coreboot/+/57642/comment/56ae1018_5b074e31 PS3, Line 36: PANEL_DCS(0xB0, 0x00, 0x08, 0x00, 0x23, 0x00, 0x4D, 0x00, 0x6D, 0x00, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128121): https://review.coreboot.org/c/coreboot/+/57642/comment/72d5f932_ef68c67e PS3, Line 38: PANEL_DCS(0xB1, 0x00, 0xDA, 0x01, 0x13, 0x01, 0x3C, 0x01, 0x7E, 0x01, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128121): https://review.coreboot.org/c/coreboot/+/57642/comment/4cb4c528_1f0d982d PS3, Line 40: PANEL_DCS(0xB2, 0x02, 0x67, 0x02, 0xA6, 0x02, 0xD1, 0x03, 0x08, 0x03, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128121): https://review.coreboot.org/c/coreboot/+/57642/comment/670f9a82_d94787de PS3, Line 42: PANEL_DCS(0xB3, 0x03, 0x8E, 0x03, 0xA2, 0x03, 0xB7, 0x03, 0xE7, 0x03, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128121): https://review.coreboot.org/c/coreboot/+/57642/comment/00a79d3d_1d61e4e5 PS3, Line 44: PANEL_DCS(0xB4, 0x00, 0x08, 0x00, 0x23, 0x00, 0x4D, 0x00, 0x6D, 0x00, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128121): https://review.coreboot.org/c/coreboot/+/57642/comment/2ce11a53_72f24386 PS3, Line 46: PANEL_DCS(0xB5, 0x00, 0xDA, 0x01, 0x13, 0x01, 0x3C, 0x01, 0x7E, 0x01, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128121): https://review.coreboot.org/c/coreboot/+/57642/comment/482d22ee_8f08f394 PS3, Line 48: PANEL_DCS(0xB6, 0x02, 0x67, 0x02, 0xA6, 0x02, 0xD1, 0x03, 0x08, 0x03, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128121): https://review.coreboot.org/c/coreboot/+/57642/comment/7657440d_da9627aa PS3, Line 50: PANEL_DCS(0xB7, 0x03, 0x8E, 0x03, 0xA2, 0x03, 0xB7, 0x03, 0xE7, 0x03, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128121): https://review.coreboot.org/c/coreboot/+/57642/comment/cf254058_368c2ef4 PS3, Line 52: PANEL_DCS(0xB8, 0x00, 0x08, 0x00, 0x23, 0x00, 0x4D, 0x00, 0x6D, 0x00, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128121): https://review.coreboot.org/c/coreboot/+/57642/comment/caf697cf_32a5546c PS3, Line 54: PANEL_DCS(0xB9, 0x00, 0xDA, 0x01, 0x13, 0x01, 0x3C, 0x01, 0x7E, 0x01, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128121): https://review.coreboot.org/c/coreboot/+/57642/comment/01cf9b21_f171a742 PS3, Line 56: PANEL_DCS(0xBA, 0x02, 0x67, 0x02, 0xA6, 0x02, 0xD1, 0x03, 0x08, 0x03, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128121): https://review.coreboot.org/c/coreboot/+/57642/comment/c0e88f7b_0d3929ce PS3, Line 58: PANEL_DCS(0xBB, 0x03, 0x8E, 0x03, 0xA2, 0x03, 0xB7, 0x03, 0xE7, 0x03, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128121): https://review.coreboot.org/c/coreboot/+/57642/comment/5293c4e3_cb7bcd85 PS3, Line 62: PANEL_DCS(0xB0, 0x00, 0x00, 0x00, 0x1B, 0x00, 0x45, 0x00, 0x65, 0x00, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128121): https://review.coreboot.org/c/coreboot/+/57642/comment/53a2d150_1ecc5c6c PS3, Line 64: PANEL_DCS(0xB1, 0x00, 0xD2, 0x01, 0x0B, 0x01, 0x34, 0x01, 0x76, 0x01, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128121): https://review.coreboot.org/c/coreboot/+/57642/comment/870ecc2e_97988e78 PS3, Line 66: PANEL_DCS(0xB2, 0x02, 0x5F, 0x02, 0x9E, 0x02, 0xC9, 0x03, 0x00, 0x03, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128121): https://review.coreboot.org/c/coreboot/+/57642/comment/c6891713_ca0057a2 PS3, Line 68: PANEL_DCS(0xB3, 0x03, 0x86, 0x03, 0x9A, 0x03, 0xAF, 0x03, 0xDF, 0x03, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128121): https://review.coreboot.org/c/coreboot/+/57642/comment/47ab444b_ca3628b4 PS3, Line 70: PANEL_DCS(0xB4, 0x00, 0x00, 0x00, 0x1B, 0x00, 0x45, 0x00, 0x65, 0x00, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128121): https://review.coreboot.org/c/coreboot/+/57642/comment/bdff77f8_409ab7da PS3, Line 72: PANEL_DCS(0xB5, 0x00, 0xD2, 0x01, 0x0B, 0x01, 0x34, 0x01, 0x76, 0x01, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128121): https://review.coreboot.org/c/coreboot/+/57642/comment/5b181832_50c1e50e PS3, Line 74: PANEL_DCS(0xB6, 0x02, 0x5F, 0x02, 0x9E, 0x02, 0xC9, 0x03, 0x00, 0x03, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128121): https://review.coreboot.org/c/coreboot/+/57642/comment/41a9cc58_c1e421d0 PS3, Line 76: PANEL_DCS(0xB7, 0x03, 0x86, 0x03, 0x9A, 0x03, 0xAF, 0x03, 0xDF, 0x03, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128121): https://review.coreboot.org/c/coreboot/+/57642/comment/17d69230_c0449f99 PS3, Line 78: PANEL_DCS(0xB8, 0x00, 0x00, 0x00, 0x1B, 0x00, 0x45, 0x00, 0x65, 0x00, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128121): https://review.coreboot.org/c/coreboot/+/57642/comment/422b2094_56895b8e PS3, Line 80: PANEL_DCS(0xB9, 0x00, 0xD2, 0x01, 0x0B, 0x01, 0x34, 0x01, 0x76, 0x01, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128121): https://review.coreboot.org/c/coreboot/+/57642/comment/0c97ac8e_b083db9d PS3, Line 82: PANEL_DCS(0xBA, 0x02, 0x5F, 0x02, 0x9E, 0x02, 0xC9, 0x03, 0x00, 0x03, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128121): https://review.coreboot.org/c/coreboot/+/57642/comment/efadb553_73029ae4 PS3, Line 84: PANEL_DCS(0xBB, 0x03, 0x86, 0x03, 0x9A, 0x03, 0xAF, 0x03, 0xDF, 0x03, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128121): https://review.coreboot.org/c/coreboot/+/57642/comment/4602c98a_cc820d7f PS3, Line 166: PANEL_DCS(0xB6, 0x05, 0x00, 0x05, 0x00, 0x00, 0x00, 0x00, 0x00, 0x05, \ Avoid unnecessary line continuations
-
build bot (Jenkins) (Code Review)