Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Ben McMillen, Elyes Haouas.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/65785 )
Change subject: mb/starlabs/starbook: Add Alder Lake StarBook Mk VI variant
......................................................................
Patch Set 27:
(3 comments)
File src/mainboard/starlabs/starbook/variants/adl/gpio.c:
PS14:
suggestion: include the net names instead of just e.g. […]
Done
https://review.coreboot.org/c/coreboot/+/65785/comment/7eb1d770_21dd956f
PS14, Line 37: /* GPD8: Suspend Clock */
: PAD_CFG_NF(GPD8, NONE, DEEP, NF1),
: /* GPD9: Wireless LAN Sleep
Looks connected to M. […]
Done
https://review.coreboot.org/c/coreboot/+/65785/comment/eedadc62_92862ea0
PS14, Line 103: /* B7: I2C 3 SDA Test Point 15 */
: PAD_NC(GPP_B7, NONE),
: /* B8: I2C 3 SCL Test Point 16 */
: PAD_NC(GPP_B8, NONE),
I2c3 not used, should be NC?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/65785
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idc0c265a88b19cf9e89cc8ab3e8db9abd8cf8409
Gerrit-Change-Number: 65785
Gerrit-PatchSet: 27
Gerrit-Owner: Ben McMillen
ben@starlabs.systems
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Sean Rhodes
sean@starlabs.systems
Gerrit-CC: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Ben McMillen
ben@starlabs.systems
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Sun, 13 Nov 2022 21:10:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Rhodes
sean@starlabs.systems
Comment-In-Reply-To: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-MessageType: comment