Attention is currently required from: Nicholas Chin.
Hello Nicholas Chin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80695?usp=email
to look at the new patch set (#3).
Change subject: include/device: Merge enums from azalia_device.h and azalia.h ......................................................................
include/device: Merge enums from azalia_device.h and azalia.h
We were keeping 2 copies of the same thing (albeit there were some slight differences). As azalia_device.h is used much more in the codebase this was kept as the base and then some of the nice features of azalia.h were incorporated.
The significant changes are: - All enum names now use the `AZALIA_` prefix. - Locations are now expressed using a combination of ORs (e.g. `AZALIA_EXTERNAL_PRIMARY_CHASSIS | AZALIA_FRONT`).
This also drops the AzaliaPinConfiguration enum as it was never used since added in 2013.
Change-Id: Ie874b083a18963679981a9cd2b25d123890d628e Signed-off-by: Nicholas Sudsgaard devel+coreboot@nsudsgaard.com --- D src/include/device/azalia.h M src/include/device/azalia_device.h M src/mainboard/clevo/tgl-u/variants/l140mu/hda_verb.c M src/mainboard/siemens/chili/variants/chili/hda_verb.c 4 files changed, 162 insertions(+), 259 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/80695/3