Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43768 )
Change subject: drivers/wifi: Adapt generic wifi driver into a chip driver ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43768/4/src/drivers/wifi/generic/ge... File src/drivers/wifi/generic/generic.c:
https://review.coreboot.org/c/coreboot/+/43768/4/src/drivers/wifi/generic/ge... PS4, Line 243: #if CONFIG(HAVE_ACPI_TABLES)
nit: Not required. This file is added only when HAVE_ACPI_TABLES is selected.
Done
https://review.coreboot.org/c/coreboot/+/43768/4/src/drivers/wifi/generic/ge... PS4, Line 251: struct drivers_wifi_generic_config *config = dev->chip_info;
Eep, good catch.
Done
-
Karthik Ramasubramanian (Code Review)