Attention is currently required from: Sean Rhodes, Tarun Tuli, Subrata Banik, Paul Menzel, Arthur Heymans.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71715 )
Change subject: soc/intel/alderlake: Hook up PchHdaAudioLinkHdaEnable to devicetree
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/71715/comment/1334c4d6_f9a0d60a
PS3, Line 10: Setting this GPIO to 1 or 0 will not change the GPIO
: configuration
I'm not sure I understand. […]
Setting this UPD to 1 or 0 will not change the HDA GPIO configuration
This is what Sean meant probably... I missed it.
https://review.coreboot.org/c/coreboot/+/71715/comment/319dcc7e_b9151eb1
PS3, Line 15:
Does this revert I90e4eb5cc242a789800f4c9f8c71e9d8c8a2becf (commit c1c1ba5582fa (soc/intel/alderlake […]
They dropped one UPD more than needed.
PchHdaAudioLink{Hda|Dmic|Ssp|Sndw} are responsible for GPIO configuration but PchHdaAudioLinkHda additionally controls if HDA SDI pins are enabled or disabled via sideband PCR register. HDA GPIOs are not touched because coreboot sets GpioOverride to 1.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71715
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6f27f41a4a4b3844a65d45d36aba37c3af1050a0
Gerrit-Change-Number: 71715
Gerrit-PatchSet: 3
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 13 Jan 2023 11:05:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment