build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35402 )
Change subject: soc/intel/common/block/cse: Add boot partition related APIs ......................................................................
Patch Set 55:
(10 comments)
https://review.coreboot.org/c/coreboot/+/35402/55/src/soc/intel/common/block... File src/soc/intel/common/block/cse/cse_bp.c:
https://review.coreboot.org/c/coreboot/+/35402/55/src/soc/intel/common/block... PS55, Line 101: if (!cse_update_boot_partition_info()) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/35402/55/src/soc/intel/common/block... PS55, Line 260: (bp_status == BP_STATUS_GENERAL_FAILURE || bp_status == BP_STATUS_CORRUPTED)) { line over 96 characters
https://review.coreboot.org/c/coreboot/+/35402/55/src/soc/intel/common/block... File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/35402/55/src/soc/intel/common/block... PS55, Line 216: /* trailing whitespace
https://review.coreboot.org/c/coreboot/+/35402/55/src/soc/intel/common/block... PS55, Line 217: * The status is return when BIOS requests CSE for boot switch. trailing whitespace
https://review.coreboot.org/c/coreboot/+/35402/55/src/soc/intel/common/block... PS55, Line 218: * This value isn't applicable to chrome platforms trailing whitespace
https://review.coreboot.org/c/coreboot/+/35402/55/src/soc/intel/common/block... PS55, Line 230: /* trailing whitespace
https://review.coreboot.org/c/coreboot/+/35402/55/src/soc/intel/common/block... PS55, Line 279: * then this command be used. Inorder to set CSE to boot from RW/RO, coreboot/BIOS must issue trailing whitespace
https://review.coreboot.org/c/coreboot/+/35402/55/src/soc/intel/common/block... PS55, Line 281: * NOTE: During CSE FW update, coreboot can notify CSE to boot from RO(BP1), and shall issue trailing whitespace
https://review.coreboot.org/c/coreboot/+/35402/55/src/soc/intel/common/block... PS55, Line 311: bool cse_get_bp_entry_status(enum boot_partition_id boot_partition, uint8_t *boot_partition_status); line over 96 characters
https://review.coreboot.org/c/coreboot/+/35402/55/src/soc/intel/common/block... PS55, Line 317: bool cse_get_bp_entry_version(enum boot_partition_id boot_partition, struct partition_fw_version *fw_version); line over 96 characters