Attention is currently required from: Paul Menzel, Kirk Wang.
Alex1 Kao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56327 )
Change subject: mb/google/dedede/var/pirika: Add USB2 PHY parameters
......................................................................
Patch Set 5: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56327/comment/d17392d3_bfb429ee
PS1, Line 7: UPSTREAM:
This is a Chromium repository tag to my knowledge. Please remove.
Done
https://review.coreboot.org/c/coreboot/+/56327/comment/76403e7b_0e9a93ef
PS1, Line 9: This change adds fine-tuned USB2 PHY parameters for pirika.
Please add, where you got these from.
Removed "UPSTREAM". I copied another project's git log but forgot to remove it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56327
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icf9fb41cd0ae40728e4ec5bd72a15ec3c45c963b
Gerrit-Change-Number: 56327
Gerrit-PatchSet: 5
Gerrit-Owner: Alex1 Kao
alex1_kao@pegatron.corp-partner.google.com
Gerrit-Reviewer: Alex1 Kao
alex1_kao@pegatron.corp-partner.google.com
Gerrit-Reviewer: Kirk Wang
kirk_wang@pegatron.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kirk Wang
kirk_wang@pegatron.corp-partner.google.com
Gerrit-Comment-Date: Fri, 16 Jul 2021 10:39:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment