Change in ...coreboot[master]: [WIP]mb/lenovo/x220/vboot-rwa.fmd: Remove unneeded offsets/sizes

[Arthur Heymans (Code Review)]

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33276

Change subject: [WIP]mb/lenovo/x220/vboot-rwa.fmd: Remove unneeded offsets/sizes
......................................................................

[WIP]mb/lenovo/x220/vboot-rwa.fmd: Remove unneeded offsets/sizes

fmaptool can deal with it and it makes the file more readable.
Not defining WR_RO and COREBOOT(CBFS) insures the bootblock is at the
bottom of the flash.

Change-Id: I4ed789acc8716942212fc5ab97fd722c8ea8c20d
Signed-off-by: Arthur Heymans 
---
M src/mainboard/lenovo/x220/vboot-rwa.fmd
1 file changed, 17 insertions(+), 17 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/33276/1

diff --git a/src/mainboard/lenovo/x220/vboot-rwa.fmd b/src/mainboard/lenovo/x220/vboot-rwa.fmd
index 8a4cd3b..be06484 100644
--- a/src/mainboard/lenovo/x220/vboot-rwa.fmd
+++ b/src/mainboard/lenovo/x220/vboot-rwa.fmd
@@ -5,25 +5,25 @@
    	SI_ME@0x3000 0x4ed000
    }
    SI_BIOS@0x500000 0x300000 {
-		RW_SECTION_A@0x00000 0x180000 {
-			VBLOCK_A@0x0 0x10000
-			FW_MAIN_A(CBFS)@0x10000 0x16ffc0
-			RW_FWID_A@0x17ffc0 0x40
+		RW_SECTION_A 0x180000 {
+			VBLOCK_A 0x10000
+			FW_MAIN_A(CBFS)
+			RW_FWID_A 0x40
    	}
-		UNIFIED_MRC_CACHE@0x180000 0x20000 {
-			RECOVERY_MRC_CACHE@0x0 0x10000
-			RW_MRC_CACHE@0x10000 0x10000
+		UNIFIED_MRC_CACHE 0x20000 {
+			RECOVERY_MRC_CACHE 0x10000
+			RW_MRC_CACHE 0x10000
    	}
-		RW_VPD(PRESERVE)@0x1a0000 0x1000
-		SMMSTORE(PRESERVE)@0x1a1000 0x40000
+		RW_VPD(PRESERVE) 0x1000
+		SMMSTORE(PRESERVE) 0x40000

-		WP_RO@0x1e1000 0x11f000 {
-			FMAP@0x0 0x800
-			RO_FRID@0x800 0x40
-			RO_PADDING@0x840 0x7c0
-			RO_VPD(PRESERVE)@0x1000 0x1000
-			GBB@0x2000 0x1e000
-			COREBOOT(CBFS)@0x20000 0xff000
-		}
+		WP_RO {
+			FMAP 0x800
+			RO_FRID 0x40
+			RO_PADDING 0x7c0
+			RO_VPD(PRESERVE) 0x1000
+			GBB 0x1e000
+			COREBOOT(CBFS)
+                 }
    }
 }

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33276 )

Change subject: [WIP]mb/lenovo/x220/vboot-rwa.fmd: Remove unneeded offsets/sizes
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/33276/1/src/mainboard/lenovo/x220/vboot-rwa.... 
File src/mainboard/lenovo/x220/vboot-rwa.fmd:

https://review.coreboot.org/#/c/33276/1/src/mainboard/lenovo/x220/vboot-rwa.... 
PS1, Line 27:                  
tab?

Change in coreboot[master]: [WIP]mb/lenovo/x220/vboot-rwa.fmd: Remove unneeded offsets/sizes

[Arthur Heymans (Code Review)]

Arthur Heymans has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33276 )

Change subject: [WIP]mb/lenovo/x220/vboot-rwa.fmd: Remove unneeded offsets/sizes
......................................................................

Abandoned

Not interested anymore.