Attention is currently required from: Felix Singer, Jérémy Compostella, Shuo Liu.
yuchi.chen@intel.com has posted comments on this change by yuchi.chen@intel.com. ( https://review.coreboot.org/c/coreboot/+/83320?usp=email )
Change subject: soc/intel/common/block/imc: Add Integrated Memory Controller driver
......................................................................
Patch Set 13:
(1 comment)
File src/soc/intel/common/block/smbus/smbuslib.c:
https://review.coreboot.org/c/coreboot/+/83320/comment/fc594874_7c1048d1?usp... :
PS3, Line 10: {
If not using weak, can I create a new spd. […]
Sorry for the typo, I mean in `coreboot/src/soc/intel/common/block/smbus/Makefile.mk`, add something like this:
ifneq ($(CONFIG_SOC_INTEL_COMMON_BLOCK_IMC),y)
bootblock += spd.c
romstage += spd.c
ramstage += spd.c
endif
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83320?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3f47ddeda94d3882852d64c0052f8fb42b6b7ad2
Gerrit-Change-Number: 83320
Gerrit-PatchSet: 13
Gerrit-Owner: yuchi.chen@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Vasiliy Khoruzhick
vasilykh@arista.com
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Comment-Date: Wed, 28 Aug 2024 06:17:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: yuchi.chen@intel.com
Comment-In-Reply-To: Shuo Liu
shuo.liu@intel.com