Attention is currently required from: Fred Reitberger, Jason Glenesk, Marshall Dawson, Matt DeVillier, Nick Kochlowski.
Felix Held has posted comments on this change by Nick Kochlowski. ( https://review.coreboot.org/c/coreboot/+/85195?usp=email )
Change subject: soc/amd/phoenix/pci_irq_routing.c: Populate PCI IRQ routing table
......................................................................
Patch Set 6: Code-Review+1
(1 comment)
File src/soc/amd/phoenix/pci_irq_routing.c:
https://review.coreboot.org/c/coreboot/+/85195/comment/8d28cb84_2aa1aac0?usp... :
PS6, Line 18: reserved
the reserved fields don't need to be named; see for example some of the bitfield structs in src/soc/amd/phoenix/include/soc/data_fabric.h. same below. jenkins will complain about those a bit, but that's mainly due to it being a rather uncommon thing and jenkins not knowing that construct, so i've just ignored jenkins' comments on those
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85195?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id014ff3e675831eec42bc46c0a76271341e0e3e4
Gerrit-Change-Number: 85195
Gerrit-PatchSet: 6
Gerrit-Owner: Nick Kochlowski
nickkochlowski@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Nick Kochlowski
nickkochlowski@gmail.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Mon, 09 Dec 2024 16:01:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes