Attention is currently required from: Jason Glenesk, Martin Roth, Marshall Dawson. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56273 )
Change subject: soc/amd/picasso: add missing banks to mca_bank_name array ......................................................................
Patch Set 3:
(1 comment)
File src/soc/amd/picasso/mca.c:
https://review.coreboot.org/c/coreboot/+/56273/comment/eb71792d_56183229 PS3, Line 145: [7] = "L3 cache unit", : [8] = "L3 cache unit", : [9] = "L3 cache unit", : [10] = "L3 cache unit", : [11] = "L3 cache unit", : [12] = "L3 cache unit", : [13] = "L3 cache unit", : [14] = "L3 cache unit",
With all the duplicates, would it make sense to make this a function returning the string and choose […]
or maybe define a static const string and assign it to all those array elements? would do the same thing, but i'd prefer that over a switch case statement. i'd also prefer doing that change in a follow-up patch to not block the rest of the rather big patch train and to avoid to edit and rebase the rest of the patch train
-
Felix Held (Code Review)