Frans Hendriks has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40557 )
Change subject: configs/config.faceboot_fbg1701_mboot_vboot ......................................................................
configs/config.faceboot_fbg1701_mboot_vboot
Jenskins seems not running the original .config.faceboot_fbg1701
Assume file name of config need to contains additional into to different from default 'manufacturer _ board' format
BUG=N/A TEST=Build and boot Facebook fbg1701
Change-Id: Ib54cc29e7ff34553c19fa3502872d6e7aee5fbe8 Signed-off-by: Frans Hendriks fhendriks@eltan.com --- R configs/config.facebook_fbg1701.mboot_vboot 1 file changed, 0 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/40557/1
diff --git a/configs/config.facebook_fbg1701 b/configs/config.facebook_fbg1701.mboot_vboot similarity index 100% rename from configs/config.facebook_fbg1701 rename to configs/config.facebook_fbg1701.mboot_vboot
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40557
to look at the new patch set (#2).
Change subject: configs/config.facebook_fbg1701: Rename file ......................................................................
configs/config.facebook_fbg1701: Rename file
Jenskins does not build using .config.facebook_fbg1701 on new patches.
Rename the config file adding '.mboot_vboot'. Now FACEBOOK_FBG1701 and FACEBOOK_FBG1701_MBOOT_VBOOT are included in Jenskins test result.
BUG=N/A TEST=Build and boot Facebook fbg1701
Change-Id: Ib54cc29e7ff34553c19fa3502872d6e7aee5fbe8 Signed-off-by: Frans Hendriks fhendriks@eltan.com --- R configs/config.facebook_fbg1701.mboot_vboot 1 file changed, 0 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/40557/2
Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40557 )
Change subject: configs/config.facebook_fbg1701: Rename file ......................................................................
Patch Set 2: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40557 )
Change subject: configs/config.facebook_fbg1701: Rename file ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40557/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40557/2//COMMIT_MSG@9 PS2, Line 9: Jenskins Jenkins
https://review.coreboot.org/c/coreboot/+/40557/2//COMMIT_MSG@12 PS2, Line 12: Jenskins Jenkins
Hello build bot (Jenkins), Patrick Rudolph, Wim Vervoorn,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40557
to look at the new patch set (#3).
Change subject: configs/config.facebook_fbg1701: Rename file ......................................................................
configs/config.facebook_fbg1701: Rename file
Jenkins does not build using .config.facebook_fbg1701 on new patches.
Rename the config file adding '.mboot_vboot'. Now FACEBOOK_FBG1701 and FACEBOOK_FBG1701_MBOOT_VBOOT are included in Jenkins test result.
BUG=N/A TEST=Build and boot Facebook fbg1701
Change-Id: Ib54cc29e7ff34553c19fa3502872d6e7aee5fbe8 Signed-off-by: Frans Hendriks fhendriks@eltan.com --- R configs/config.facebook_fbg1701.mboot_vboot 1 file changed, 0 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/40557/3
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40557 )
Change subject: configs/config.facebook_fbg1701: Rename file ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40557/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40557/2//COMMIT_MSG@9 PS2, Line 9: Jenskins
Jenkins
Done
https://review.coreboot.org/c/coreboot/+/40557/2//COMMIT_MSG@12 PS2, Line 12: Jenskins
Jenkins
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40557 )
Change subject: configs/config.facebook_fbg1701: Rename file ......................................................................
configs/config.facebook_fbg1701: Rename file
Jenkins does not build using .config.facebook_fbg1701 on new patches.
Rename the config file adding '.mboot_vboot'. Now FACEBOOK_FBG1701 and FACEBOOK_FBG1701_MBOOT_VBOOT are included in Jenkins test result.
BUG=N/A TEST=Build and boot Facebook fbg1701
Change-Id: Ib54cc29e7ff34553c19fa3502872d6e7aee5fbe8 Signed-off-by: Frans Hendriks fhendriks@eltan.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/40557 Reviewed-by: Wim Vervoorn wvervoorn@eltan.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- R configs/config.facebook_fbg1701.mboot_vboot 1 file changed, 0 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Wim Vervoorn: Looks good to me, approved
diff --git a/configs/config.facebook_fbg1701 b/configs/config.facebook_fbg1701.mboot_vboot similarity index 100% rename from configs/config.facebook_fbg1701 rename to configs/config.facebook_fbg1701.mboot_vboot
-
Frans Hendriks (Code Review) -
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Wim Vervoorn (Code Review)