Attention is currently required from: Justin van Son, Christian Walter, Arthur Heymans.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58879 )
Change subject: mb/prodrive/hermes: Configure pink rear vref based on eeprom
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/prodrive/hermes/variants/r04/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/58879/comment/d24749f7_7963bd54
PS1, Line 89: get_port_c_vref_cfg(board_cfg->blue_rear_vref),
Ack, thanks for confirming
Ah, looking further into the ALC888 datasheet, I understand it now. These two commands use a 4-bit verb ID. They're "Set Coefficient Index" (0x5) and Set Processing Coefficient (0x4). They use NID 0x20, "Realtek Defined Registers".
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58879
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaa11ba9c74f643e94046d4983fbce65dbedd1025
Gerrit-Change-Number: 58879
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Justin van Son
justin.van.son@prodrive-technologies.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Justin van Son
justin.van.son@prodrive-technologies.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 03 Nov 2021 11:56:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Justin van Son
justin.van.son@prodrive-technologies.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment