Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29949 )
Change subject: mainboard/google/mistral: Add support for Mistral ......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/#/c/29949/2/src/mainboard/google/mistral/chromeo... File src/mainboard/google/mistral/chromeos.fmd:
https://review.coreboot.org/#/c/29949/2/src/mainboard/google/mistral/chromeo... PS2, Line 38: RW_XBL_BUFFER_A@0x1E8000 0x4000
Ok. Infact we were asked to have the same FMAP layout as in Gale […]
I would suggest you orient yourself on the Cheza layout, since Gale is very old and many things in there may be outdated. I assume you can drop the RO_FSG section from Cheza if you don't need that and then maybe shuffle the other WP_RO parts around a bit to make more of the resulting free space usable in the COREBOOT section, but otherwise it should fit pretty well for you. (In particular, unless memory training somehow works significantly different for you than for SDM845, I suggest you stick to the model we developed for Cheza with one RO and only one (probably unused) RW section -- you can refer to T.mike for details.)
-
Julius Werner (Code Review)