[S] Change in coreboot[main]: mb/google/trulo/var/orisa: Fill in gpio.h - coreboot-gerrit

23 Jun 2024


      Attention is currently required from: Amanda Hwang, Dinesh Gehlot, Dtrain Hsu, Kapil Porwal, Nick Vaccaro, Paul Menzel, Subrata Banik.
Eric Lai has posted comments on this change by Amanda Hwang. ( https://review.coreboot.org/c/coreboot/+/83155?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/trulo/var/orisa: Fill in gpio.h
......................................................................
Patch Set 7: Code-Review+1
(1 comment)
Patchset:
PS7: 
Please also add device tree change in comment or separate another CL
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/83155?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9de842a8a66632314d5fdf6444005d34338a1100
Gerrit-Change-Number: 83155
Gerrit-PatchSet: 7
Gerrit-Owner: Amanda Hwang amanda_hwang@compal.corp-partner.google.com
Gerrit-Reviewer: Derek Huang derekhuang@google.com
Gerrit-Reviewer: Dinesh Gehlot digehlot@google.com
Gerrit-Reviewer: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Eric Lai ericllai@google.com
Gerrit-Reviewer: Kapil Porwal kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot digehlot@google.com
Gerrit-Attention: Nick Vaccaro nvaccaro@chromium.org
Gerrit-Attention: Amanda Hwang amanda_hwang@compal.corp-partner.google.com
Gerrit-Comment-Date: Mon, 24 Jun 2024 06:58:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes