Hello Kyösti Mälkki, Swift Geek (Sebastian Grzywna), Paul Menzel, Bill XIE,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/38571
to review the following change.
Change subject: mb/lenovo/t400: Move `gma-mainboard.ads` to variants ......................................................................
mb/lenovo/t400: Move `gma-mainboard.ads` to variants
Some board revisions have the straps for display port detection configured wrong. So with a single list covering all variants' possible outputs, we make libgfxinit probe unimplemented ports which may stall the GMBUS controller and delay the boot for some hundred milliseconds.
This just copies the list to the various variants with different display ports, so we can test the actual changes individually.
Change-Id: I48cdea1d71d9553b6bdbce432eae986996329239 Signed-off-by: Nico Huber nico.h@gmx.de --- M src/mainboard/lenovo/t400/Makefile.inc R src/mainboard/lenovo/t400/variants/r500/gma-mainboard.ads C src/mainboard/lenovo/t400/variants/t400/coronado-5/gma-mainboard.ads C src/mainboard/lenovo/t400/variants/t400/malibu-3/gma-mainboard.ads 4 files changed, 7 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/38571/1
diff --git a/src/mainboard/lenovo/t400/Makefile.inc b/src/mainboard/lenovo/t400/Makefile.inc index e4e6a1f..5d5669e 100644 --- a/src/mainboard/lenovo/t400/Makefile.inc +++ b/src/mainboard/lenovo/t400/Makefile.inc @@ -22,4 +22,10 @@ ramstage-y += cstates.c ramstage-y += blc.c
-ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += gma-mainboard.ads +ifeq ($(CONFIG_MAINBOARD_USE_LIBGFXINIT),y) +ramstage-$(CONFIG_BOARD_LENOVO_T400) += variants/t400/malibu-3/gma-mainboard.ads +ramstage-$(CONFIG_BOARD_LENOVO_R400) += variants/t400/malibu-3/gma-mainboard.ads +ramstage-$(CONFIG_BOARD_LENOVO_T500) += variants/t400/coronado-5/gma-mainboard.ads +ramstage-$(CONFIG_BOARD_LENOVO_W500) += variants/t400/coronado-5/gma-mainboard.ads +ramstage-$(CONFIG_BOARD_LENOVO_R500) += variants/r500/gma-mainboard.ads +endif diff --git a/src/mainboard/lenovo/t400/gma-mainboard.ads b/src/mainboard/lenovo/t400/variants/r500/gma-mainboard.ads similarity index 100% rename from src/mainboard/lenovo/t400/gma-mainboard.ads rename to src/mainboard/lenovo/t400/variants/r500/gma-mainboard.ads diff --git a/src/mainboard/lenovo/t400/gma-mainboard.ads b/src/mainboard/lenovo/t400/variants/t400/coronado-5/gma-mainboard.ads similarity index 100% copy from src/mainboard/lenovo/t400/gma-mainboard.ads copy to src/mainboard/lenovo/t400/variants/t400/coronado-5/gma-mainboard.ads diff --git a/src/mainboard/lenovo/t400/gma-mainboard.ads b/src/mainboard/lenovo/t400/variants/t400/malibu-3/gma-mainboard.ads similarity index 100% copy from src/mainboard/lenovo/t400/gma-mainboard.ads copy to src/mainboard/lenovo/t400/variants/t400/malibu-3/gma-mainboard.ads
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38571 )
Change subject: mb/lenovo/t400: Move `gma-mainboard.ads` to variants ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38571 )
Change subject: mb/lenovo/t400: Move `gma-mainboard.ads` to variants ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/38571/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38571/1//COMMIT_MSG@10 PS1, Line 10: wrong wrongly?
incorrectly?
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38571 )
Change subject: mb/lenovo/t400: Move `gma-mainboard.ads` to variants ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38571/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38571/1//COMMIT_MSG@10 PS1, Line 10: wrong
wrongly? […]
I'd use "wrongly configured"
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38571 )
Change subject: mb/lenovo/t400: Move `gma-mainboard.ads` to variants ......................................................................
Patch Set 1: Code-Review+1
Hello Kyösti Mälkki, Alexander Couzens, Patrick Rudolph, Swift Geek (Sebastian Grzywna), Angel Pons, Paul Menzel, build bot (Jenkins), Bill XIE, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38571
to look at the new patch set (#2).
Change subject: mb/lenovo/t400: Move `gma-mainboard.ads` to variants ......................................................................
mb/lenovo/t400: Move `gma-mainboard.ads` to variants
Some board revisions have the straps for display port detection wrongly configured. So with a single list covering all variants' possible outputs, we make libgfxinit probe unimplemented ports which may stall the GMBUS controller and delay the boot for some hundred milliseconds.
This just copies the list to the various variants with different display ports, so we can test the actual changes individually.
Change-Id: I48cdea1d71d9553b6bdbce432eae986996329239 Signed-off-by: Nico Huber nico.h@gmx.de --- M src/mainboard/lenovo/t400/Makefile.inc R src/mainboard/lenovo/t400/variants/r500/gma-mainboard.ads C src/mainboard/lenovo/t400/variants/t400/coronado-5/gma-mainboard.ads C src/mainboard/lenovo/t400/variants/t400/malibu-3/gma-mainboard.ads 4 files changed, 7 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/38571/2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38571 )
Change subject: mb/lenovo/t400: Move `gma-mainboard.ads` to variants ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38571/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38571/1//COMMIT_MSG@10 PS1, Line 10: wrong
I'd use "wrongly configured"
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38571 )
Change subject: mb/lenovo/t400: Move `gma-mainboard.ads` to variants ......................................................................
mb/lenovo/t400: Move `gma-mainboard.ads` to variants
Some board revisions have the straps for display port detection wrongly configured. So with a single list covering all variants' possible outputs, we make libgfxinit probe unimplemented ports which may stall the GMBUS controller and delay the boot for some hundred milliseconds.
This just copies the list to the various variants with different display ports, so we can test the actual changes individually.
Change-Id: I48cdea1d71d9553b6bdbce432eae986996329239 Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/38571 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/mainboard/lenovo/t400/Makefile.inc R src/mainboard/lenovo/t400/variants/r500/gma-mainboard.ads C src/mainboard/lenovo/t400/variants/t400/coronado-5/gma-mainboard.ads C src/mainboard/lenovo/t400/variants/t400/malibu-3/gma-mainboard.ads 4 files changed, 7 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, but someone else must approve Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/lenovo/t400/Makefile.inc b/src/mainboard/lenovo/t400/Makefile.inc index e4e6a1f..5d5669e 100644 --- a/src/mainboard/lenovo/t400/Makefile.inc +++ b/src/mainboard/lenovo/t400/Makefile.inc @@ -22,4 +22,10 @@ ramstage-y += cstates.c ramstage-y += blc.c
-ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += gma-mainboard.ads +ifeq ($(CONFIG_MAINBOARD_USE_LIBGFXINIT),y) +ramstage-$(CONFIG_BOARD_LENOVO_T400) += variants/t400/malibu-3/gma-mainboard.ads +ramstage-$(CONFIG_BOARD_LENOVO_R400) += variants/t400/malibu-3/gma-mainboard.ads +ramstage-$(CONFIG_BOARD_LENOVO_T500) += variants/t400/coronado-5/gma-mainboard.ads +ramstage-$(CONFIG_BOARD_LENOVO_W500) += variants/t400/coronado-5/gma-mainboard.ads +ramstage-$(CONFIG_BOARD_LENOVO_R500) += variants/r500/gma-mainboard.ads +endif diff --git a/src/mainboard/lenovo/t400/gma-mainboard.ads b/src/mainboard/lenovo/t400/variants/r500/gma-mainboard.ads similarity index 100% rename from src/mainboard/lenovo/t400/gma-mainboard.ads rename to src/mainboard/lenovo/t400/variants/r500/gma-mainboard.ads diff --git a/src/mainboard/lenovo/t400/gma-mainboard.ads b/src/mainboard/lenovo/t400/variants/t400/coronado-5/gma-mainboard.ads similarity index 100% copy from src/mainboard/lenovo/t400/gma-mainboard.ads copy to src/mainboard/lenovo/t400/variants/t400/coronado-5/gma-mainboard.ads diff --git a/src/mainboard/lenovo/t400/gma-mainboard.ads b/src/mainboard/lenovo/t400/variants/t400/malibu-3/gma-mainboard.ads similarity index 100% copy from src/mainboard/lenovo/t400/gma-mainboard.ads copy to src/mainboard/lenovo/t400/variants/t400/malibu-3/gma-mainboard.ads
-
Angel Pons (Code Review) -
Kyösti Mälkki (Code Review)
-
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)