Attention is currently required from: Martin L Roth, Martin Roth.
Solomon Alan-Dei has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66637 )
Change subject: util/lint: fall back to regular grep in kconfig_lint ......................................................................
Patch Set 6:
(11 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/66637/comment/f2b9c6fb_b95fe28e PS1, Line 7: fallback
"fall back"?
Done
https://review.coreboot.org/c/coreboot/+/66637/comment/e2d143ce_87f197a4 PS1, Line 7: util/lint: fallback to regular grep
... […]
Done
Patchset:
PS6: Thank you for pointing out the issues. Kindly check to confirm if they are resolved.
File util/lint/kconfig_lint:
https://review.coreboot.org/c/coreboot/+/66637/comment/a129b11d_54a91000 PS1, Line 60: if
Move this after check_arguments and only check if -G isn't specified?
Done
https://review.coreboot.org/c/coreboot/+/66637/comment/2fb431ab_1f10a183 PS1, Line 61:
Make sure this matches the rest of the file - it looks like there are only spaces used for indentati […]
Done
https://review.coreboot.org/c/coreboot/+/66637/comment/a010279f_4b5383e9 PS1, Line 62: print
Oh, we probably want this to come out on STDERR insted of stdio.
Done
https://review.coreboot.org/c/coreboot/+/66637/comment/d4830edf_3c039e4a PS1, Line 62: nFalling
"Git grep unavailable, falling... […]
Done
File util/lint/kconfig_lint:
https://review.coreboot.org/c/coreboot/+/66637/comment/1d667eec_3b42bf24 PS4, Line 62: if ( !($dont_use_git_grep) ) { : if ( !(`git rev-parse --is-inside-work-tree`) ) {
use 'if ( () && () )' instead of one if inside the other. […]
Done
https://review.coreboot.org/c/coreboot/+/66637/comment/c87ef57e_348c3e44 PS4, Line 64: $dont_
These two lines are indented one level too many.
Done
https://review.coreboot.org/c/coreboot/+/66637/comment/dc68ea2e_7ceeaf34 PS4, Line 65: print
We want to print this to STDERR instead of STDOUT. […]
Done
https://review.coreboot.org/c/coreboot/+/66637/comment/de1d11ab_72249893 PS4, Line 68:
You should fix the whitespace above on lines 63 & 66. […]
Done