Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43494 )
Change subject: soc/intel/common/cpu: Update COS mask calculation for NEM enhanced mode
......................................................................
Patch Set 4:
Patch Set 4:
Patch Set 4:
Patch Set 4:
Patch Set 4:
Patch Set 4:
Patch Set 4:
FYI I was able to boot my Volteer with this patch & adding COS_MAPPED_TO_MSB and USE_CAR_NEM_ENHANCED_V1 to the Kconfig.
Thanks for checking Tim :-)
TGL can select USE_CAR_NEM_ENHANCED_V2.
Oops, yeah that was a typo in Gerrit not in the code, I did use V2 in my Kconfig 😄
Hi Tim, did you use Volteer QS / Volteer EVT? Because on Volteer ES2, we would see that these 2 MSRs are not accessible.
I just thought about that, no it was on proto2. I just received my other board, I will try it out soon.
Ok. Thanks the info.
I can confirm my volteer2 (should be QS) boots with this patch and the 2 Kconfigs selected. I am not aware of any other mechanism to verify the CQOS is set up correctly
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43494
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I54e047161853bfc70516c1d607aa479e68836d04
Gerrit-Change-Number: 43494
Gerrit-PatchSet: 4
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-CC: Nick Vaccaro
nvaccaro@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Shreesh Chhabbi
shreesh.chhabbi@intel.com
Gerrit-Comment-Date: Tue, 11 Aug 2020 19:31:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment