Change in coreboot[master]: utils/abuild: select FSP_USE_REPO instead of ADD_FSP_BINARIES - coreboot-gerrit

3 Sep 2021


      Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57349 )
Change subject: utils/abuild: select FSP_USE_REPO instead of ADD_FSP_BINARIES
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
...
Should we split the ADD_FSP_BINARIES for AMD & Intel?  Select it only for intel boards if FSP_USE_RE […]
in the Intel case ADD_FSP_BINARIES is default y if FSP_USE_REPO and I added select ADD_FSP_BINARIES if USE_AMD_BLOBS for Picasso which is currently the only AMD platform with published FSP. might be a good idea to rename FSP_USE_REPO to FSP_USE_INTEL_REPO, but I'm not sure if that'll break local configs
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/57349
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I72faa6f9e5f2b06ab7cd43595ae0b49bf4d39630
Gerrit-Change-Number: 57349
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Comment-Date: Fri, 03 Sep 2021 16:17:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth martinroth@google.com
Gerrit-MessageType: comment