Attention is currently required from: Christian Walter, Elyes Haouas, Felix Held, Felix Singer, Martin L Roth, Paul Menzel.
Naveen Iyer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82006?usp=email )
Change subject: Makefile.mk: Associate reproducible build to commit ID ......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82006/comment/6dc2214c_b21fa155 : PS3, Line 14:
Please describe how it works. You introduce `BUILD_TIMELESS_WITH_GITREV`. […]
Ya I was also hoping to find something about BUILD_TIMELESS inside Documentation/, but didn't find anything. I suppose the right place to document it would be in Makefile.mk itself since that's the first place to look at for all these cmdline options for the `make` cmd, from my limited understanding. Let me know if you think otherwise.
I also see how util/genbuild_h/genbuild_h.sh generates build.h, but did not need any change there for my specific testing of the built binary. However, in order to stay consistent I have added this new option there as well. Same goes for build_h_exports. I didn't need that while testing the built binary.
The way I tested originally (before this new patch) was to use QEMU to boot the built coreboot ELF payload. Once it booted, I pressed F2 for firmware options where I saw the version as the commit ID. Hence, didn't feel the need to add those additional stuff, like the modifications to util/genbuild_h/genbuild_h.sh and build_h_exports variable (in Makefile.mk).
Patchset:
PS3:
Nice work. […]
I was misled by some online forum where I read that I might need to do it to ensure progress. Now I know that its not true. My apologies, I'm new to this. I've removed my +1 review. Thanks!