Attention is currently required from: Arthur Heymans, Nicholas Sudsgaard.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80720?usp=email )
Change subject: mb/clevo/tgl-u: hda_verbs: correct vendor value comments
......................................................................
Patch Set 2:
(3 comments)
Patchset:
PS1:
Just my 2 cents, maybe the `/* vendor/linux: AZALIA_... */` comments are superfluous. […]
I still like to keep them
PS1:
Ignore this. I accidentally marked this as resolved.
CB:80727 should go before this change as well; rebase that on top of CB:80740 first?
File src/mainboard/clevo/tgl-u/variants/l140mu/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/80720/comment/f2455ef4_13098312 :
PS1, Line 54: vendor
linux.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80720?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I45b1d09d5a11b357ac2a20ef448ea642540cdc99
Gerrit-Change-Number: 80720
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Mon, 26 Feb 2024 10:58:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Gerrit-MessageType: comment