Attention is currently required from: Angel Pons, Arthur Heymans, Christian Walter, Felix Held, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Nico Huber, Patrick Rudolph, Tim Chu.
Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82034?usp=email )
Change subject: soc/intel/xeon_sp: Add _OSC ASL generation utils for IIO stacks
......................................................................
Patch Set 3:
(6 comments)
File src/soc/intel/xeon_sp/acpi/iiostack.asl:
https://review.coreboot.org/c/coreboot/+/82034/comment/f854fb17_3af6e986 :
PS2, Line 75: CreateDWordField (Local7, Zero, QSUP)
I fail to find any use of this.
Done
https://review.coreboot.org/c/coreboot/+/82034/comment/448d8e7d_a7ec6354 :
PS2, Line 87: (OscArg0 == ToUUID (CXL_HOST_BRIDGE_OSC_UUID)))
Doesn't this need an `IsCxlDomain != 0` too?
Done
https://review.coreboot.org/c/coreboot/+/82034/comment/ebb7438e_0c0cf777 :
PS2, Line 89: 0x02
3?
Done
https://review.coreboot.org/c/coreboot/+/82034/comment/8de4fd71_fdccbdb4 :
PS2, Line 99: ToInteger
Isn't a DWord an Integer already?
Done
https://review.coreboot.org/c/coreboot/+/82034/comment/5a7534d8_5736771b :
PS2, Line 104: SUPL
What is SUPL?
Done
https://review.coreboot.org/c/coreboot/+/82034/comment/ca302347_cfceb809 :
PS2, Line 117: 0x04
5?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82034?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibd3bfa2428725fe593754436d5ed75a3a11b4cdc
Gerrit-Change-Number: 82034
Gerrit-PatchSet: 3
Gerrit-Owner: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Tue, 23 Apr 2024 07:52:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment