Attention is currently required from: Christian Walter, Jincheng Li, Jérémy Compostella, Patrick Rudolph, Shuo Liu, Subrata Banik, Uwe Poeche, yuchi.chen@intel.com.
Hello Christian Walter, Jincheng Li, Jérémy Compostella, Shuo Liu, Subrata Banik, Uwe Poeche, build bot (Jenkins), siemens-bot, yuchi.chen@intel.com,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85568?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed: Code-Review+1 by Jérémy Compostella, Code-Review+1 by Uwe Poeche, Code-Review+2 by Christian Walter, Code-Review+2 by Shuo Liu, Verified+1 by build bot (Jenkins), Verified+1 by siemens-bot
The change is no longer submittable: Code-Review and Verified are unsatisfied now.
Change subject: cpu/intel/car/romstage: Fix false-positive stack corruption ......................................................................
cpu/intel/car/romstage: Fix false-positive stack corruption
Fix regression introduced in commit 03518727313119a8c7a273eb745663c99f8e4d22 ("arch/x86: Add breakpoint to stack canary").
romstage_main writes to the stack-canary, but since that's expected temporarily disable the breakpoint. This only caused a warning on platforms that do select IDT_IN_EVERY_STAGE, since those install the stack canary breakpoint.
TEST: No more exceptions are printed in romstage when IDT_IN_EVERY_STAGE is enabled.
Change-Id: I7ebf0a5e8eaad49af77ab4d5f6b58fc849013b14 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/cpu/intel/car/romstage.c 1 file changed, 18 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/85568/2