Attention is currently required from: Tim Wawrzynczak, Robert Chen. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60331 )
Change subject: mb/google/brya/var/vell: Add AMP driver setting ......................................................................
Patch Set 6: Verified+1
(6 comments)
File src/drivers/i2c/cs35l53/cs35l53.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136607): https://review.coreboot.org/c/coreboot/+/60331/comment/39e0bc0b_a6c0d961 PS6, Line 70: if ((config->boost_peak_milliamp > 4500) || that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136607): https://review.coreboot.org/c/coreboot/+/60331/comment/ffe1eea4_4215773a PS6, Line 83: acpi_dp_add_integer(dsd, "cirrus,gpio1-polarity-invert", config->gpio1_polarity_invert ? 1 : 0); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136607): https://review.coreboot.org/c/coreboot/+/60331/comment/b17daf97_16fb7aa5 PS6, Line 84: acpi_dp_add_integer(dsd, "cirrus,gpio1-output-enable", config->gpio1_output_enable ? 1 : 0); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136607): https://review.coreboot.org/c/coreboot/+/60331/comment/6a0a4351_464d972f PS6, Line 86: acpi_dp_add_integer(dsd, "cirrus,gpio2-polarity-invert", config->gpio2_polarity_invert ? 1 : 0); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136607): https://review.coreboot.org/c/coreboot/+/60331/comment/7d0f0715_774cf97b PS6, Line 87: acpi_dp_add_integer(dsd, "cirrus,gpio2-output-enable", config->gpio2_output_enable ? 1 : 0); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136607): https://review.coreboot.org/c/coreboot/+/60331/comment/59ffa01d_ef22669b PS6, Line 109: if (config->name) suspect code indent for conditional statements (0, 0)
-
build bot (Jenkins) (Code Review)