Attention is currently required from: Rex-BC Chen, Paul Menzel, Yu-Ping Wu, Felix Held. Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57270 )
Change subject: soc/mediatek: preserve WDT reset reason for debugging ......................................................................
Patch Set 4:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57270/comment/439a3ed2_37c69974 PS4, Line 10: reserve preserve
https://review.coreboot.org/c/coreboot/+/57270/comment/711d4ab9_91624e11 PS4, Line 11: reserve preserved
File src/soc/mediatek/common/wdt.c:
https://review.coreboot.org/c/coreboot/+/57270/comment/b0bbada6_1dd972ee PS2, Line 22: write32(&mtk_wdt->wdt_swrst, MTK_WDT_SWRST_KEY);
do_board_reset https://review.coreboot. […]
the common/reset.c may be overridden by mainboard reset.c; in fact, all google mainboards (kukui, asurada, cherry) do have a different implementation as `gpio_output(GPIO_RESET, 1);`.
@Rex, which is the right way to do secondary reset?
File src/soc/mediatek/common/wdt.c:
https://review.coreboot.org/c/coreboot/+/57270/comment/484d918a_542f6b77 PS4, Line 23: write32(&mtk_wdt->wdt_swrst, MTK_WDT_SWRST_KEY); add a comment before this:
/* do a secondary reset. */