EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47554 )
Change subject: mb/google/zork/: Enable REGULATORY_DOMAIN on Vilboz ......................................................................
mb/google/zork/: Enable REGULATORY_DOMAIN on Vilboz
WRDD table is needed for Intel WiFi module to enable SAR function.
BUG=b:173066178 BRANCH=zork TEST=dump ACPI and check WRDD exist with Intel WiFi module.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I9fd6fd19ed188f7ab91faab9e2599b9b09ca5b22 --- M src/mainboard/google/zork/Kconfig.name 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/47554/1
diff --git a/src/mainboard/google/zork/Kconfig.name b/src/mainboard/google/zork/Kconfig.name index 8ed43f0..cd2beca 100644 --- a/src/mainboard/google/zork/Kconfig.name +++ b/src/mainboard/google/zork/Kconfig.name @@ -7,6 +7,7 @@ config BOARD_GOOGLE_VILBOZ bool "-> Vilboz" select BOARD_GOOGLE_BASEBOARD_DALBOZ + select HAVE_REGULATORY_DOMAIN
config BOARD_GOOGLE_EZKINIL bool "-> Ezkinil"
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47554 )
Change subject: mb/google/zork/: Enable REGULATORY_DOMAIN on Vilboz ......................................................................
Patch Set 1:
I verified this patch, it is worked. Please help review, if you want move to general config, I can do it.
Hello build bot (Jenkins), Furquan Shaikh, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47554
to look at the new patch set (#2).
Change subject: mb/google/zork/: Enable REGULATORY_DOMAIN on Vilboz ......................................................................
mb/google/zork/: Enable REGULATORY_DOMAIN on Vilboz
WRDD table is needed for Intel WiFi module to enable SAR function.
BUG=b:173066178 BRANCH=zork TEST=dump ACPI and check WRDD exist with Intel WiFi module.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I9fd6fd19ed188f7ab91faab9e2599b9b09ca5b22 --- M src/mainboard/google/zork/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/47554/2
Amanda Hwang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47554 )
Change subject: mb/google/zork/: Enable REGULATORY_DOMAIN on Vilboz ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47554 )
Change subject: mb/google/zork/: Enable REGULATORY_DOMAIN on Vilboz ......................................................................
mb/google/zork/: Enable REGULATORY_DOMAIN on Vilboz
WRDD table is needed for Intel WiFi module to enable SAR function.
BUG=b:173066178 BRANCH=zork TEST=dump ACPI and check WRDD exist with Intel WiFi module.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I9fd6fd19ed188f7ab91faab9e2599b9b09ca5b22 Reviewed-on: https://review.coreboot.org/c/coreboot/+/47554 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Amanda Hwang amanda_hwang@compal.corp-partner.google.com --- M src/mainboard/google/zork/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Amanda Hwang: Looks good to me, approved
diff --git a/src/mainboard/google/zork/Kconfig b/src/mainboard/google/zork/Kconfig index 320f668..041a4e7 100644 --- a/src/mainboard/google/zork/Kconfig +++ b/src/mainboard/google/zork/Kconfig @@ -279,5 +279,6 @@ select SAR_ENABLE select USE_SAR select GEO_SAR_ENABLE + select HAVE_REGULATORY_DOMAIN if BOARD_GOOGLE_VILBOZ
endif # BOARD_GOOGLE_BASEBOARD_TREMBYLE || BOARD_GOOGLE_BASEBOARD_DALBOZ
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47554 )
Change subject: mb/google/zork/: Enable REGULATORY_DOMAIN on Vilboz ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47554/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47554/3//COMMIT_MSG@9 PS3, Line 9: WRDD table is needed for Intel WiFi module to enable SAR function. That doesn't sound right. All other zork devices with Intel WiFi modules are using SAR without WRDD.
https://review.coreboot.org/c/coreboot/+/47554/3/src/mainboard/google/zork/K... File src/mainboard/google/zork/Kconfig:
https://review.coreboot.org/c/coreboot/+/47554/3/src/mainboard/google/zork/K... PS3, Line 282: select HAVE_REGULATORY_DOMAIN if BOARD_GOOGLE_VILBOZ Sorry about the late review. It is not clear to me why this Kconfig is required for Vilboz specifically.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47554 )
Change subject: mb/google/zork/: Enable REGULATORY_DOMAIN on Vilboz ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47554/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47554/3//COMMIT_MSG@9 PS3, Line 9: WRDD table is needed for Intel WiFi module to enable SAR function.
That doesn't sound right. All other zork devices with Intel WiFi modules are using SAR without WRDD.
This is confirmed by Intel WiFi team Matt in the issue tracker.
https://review.coreboot.org/c/coreboot/+/47554/3/src/mainboard/google/zork/K... File src/mainboard/google/zork/Kconfig:
https://review.coreboot.org/c/coreboot/+/47554/3/src/mainboard/google/zork/K... PS3, Line 282: select HAVE_REGULATORY_DOMAIN if BOARD_GOOGLE_VILBOZ
Sorry about the late review. […]
Oh, I've ask in the coreboot do I open it for all zork board. I don't know any of other boards which uses the Intel module. I can add another patch for it if you want.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47554 )
Change subject: mb/google/zork/: Enable REGULATORY_DOMAIN on Vilboz ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47554/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47554/3//COMMIT_MSG@9 PS3, Line 9: WRDD table is needed for Intel WiFi module to enable SAR function.
This is confirmed by Intel WiFi team Matt in the issue tracker.
Matt replied: WRDD/WRDS/EWRD/WGDS are all needed for SAR. But is more up to the project request.
WRDD is only working for China and Indonesia cases. You can refer to the way how Intel platform is working to determine what you are going to port the codes into your coreboot. ---------- And our test team is in china...so I enable it for them.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47554 )
Change subject: mb/google/zork/: Enable REGULATORY_DOMAIN on Vilboz ......................................................................
Patch Set 3:
I have posted some questions on the bug for follow-up.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47554 )
Change subject: mb/google/zork/: Enable REGULATORY_DOMAIN on Vilboz ......................................................................
Patch Set 3:
Patch Set 3:
I have posted some questions on the bug for follow-up.
Sure, SGTM. I want to know this as well.
-
Amanda Hwang (Code Review) -
EricR Lai (Code Review)
-
Furquan Shaikh (Code Review)
-
Patrick Georgi (Code Review)