Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31995 )
Change subject: arch/mips: Fix <arch/mmio.h> prototypes ......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/31995/4/src/arch/mips/include/arch/mmio.h File src/arch/mips/include/arch/mmio.h:
https://review.coreboot.org/#/c/31995/4/src/arch/mips/include/arch/mmio.h@68 PS4, Line 68: #define write32_x(addr, val) write32((void *)(addr), (val)) Why not just
for f in $(find src/soc/imgtec -type f); do sed -i -e 's/(write|read)(8|16|32)(([^,]*[,)])/\1\2((void *)(\3)/g' $f; done
?