Werner Zeh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/51176 )
Change subject: src/drivers/i2c/rx6110sa: Add official ACPI ID ......................................................................
src/drivers/i2c/rx6110sa: Add official ACPI ID
In patch CB:47706 the randomly and therefore wrong assigned ACPI ID for RTC RX6110SA was removed. In the meantime Seiko-Epson did a great job and have registered an official vendor ID in the ACPI database [1]. Further on, Seiko-Epson have now assigned the unique Product Identifier for the RX6110SA, which is '6110'. The assignment of the Product Identifier is controlled by the vendor and there is no official database where this ID is stored in. It is up to the vendor to make sure that this ID stays unique.
This patch adds this new vendor and product ID to the driver. Together with a pending Linux patch this RTC is now useable as ACPI device in Linux.
[1] https://uefi.org/ACPI_ID_List?search=SECC
Change-Id: I45838162f014a760520692c6dcaae329ad98547d Signed-off-by: Werner Zeh werner.zeh@siemens.com --- M src/drivers/i2c/rx6110sa/rx6110sa.c M src/drivers/i2c/rx6110sa/rx6110sa.h 2 files changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/51176/1
diff --git a/src/drivers/i2c/rx6110sa/rx6110sa.c b/src/drivers/i2c/rx6110sa/rx6110sa.c index 210444e..2b8b9b2 100644 --- a/src/drivers/i2c/rx6110sa/rx6110sa.c +++ b/src/drivers/i2c/rx6110sa/rx6110sa.c @@ -198,6 +198,7 @@ /* Device */ acpigen_write_scope(scope); acpigen_write_device(acpi_device_name(dev)); + acpigen_write_name_string("_HID", RX6110SA_HID_NAME); acpigen_write_name_string("_DDN", RX6110SA_HID_DESC); acpigen_write_STA(acpi_device_status(dev));
diff --git a/src/drivers/i2c/rx6110sa/rx6110sa.h b/src/drivers/i2c/rx6110sa/rx6110sa.h index fc0109d..5be6be7 100644 --- a/src/drivers/i2c/rx6110sa/rx6110sa.h +++ b/src/drivers/i2c/rx6110sa/rx6110sa.h @@ -4,6 +4,7 @@ #define _I2C_RX6110SA_H_
#define RX6110SA_ACPI_NAME "ERX6" +#define RX6110SA_HID_NAME "SECC6110" #define RX6110SA_HID_DESC "Real Time Clock"
/* Register layout */