Change in coreboot[master]: mb/google/drallion/variants/drallion: Adjust all I2C CLK to meet spec

List overview All Threads
Download

newer

older

Change in coreboot[master]: Create...

Change in coreboot[master]:...

John Su (Code Review)

26 Nov 2019 26 Nov '19

2:44 a.m.

John Su has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37230 )

Change subject: mb/google/drallion/variants/drallion: Adjust all I2C CLK to meet spec ......................................................................

mb/google/drallion/variants/drallion: Adjust all I2C CLK to meet spec

After adjustment on Drallion Touch Pad CLK: KHz Touch Screen CLK: KHz H1 CLK: KHz

BUG=b:144245601 BRANCH=master TEST=emerge-drallion coreboot chromeos-bootimage measure by scope with drallion.

Change-Id: Id669d7199bc6ed4b55d7542f095c6c8baf00f984 Signed-off-by: John Su john_su@compal.corp-partner.google.com --- M src/mainboard/google/drallion/variants/drallion/devicetree.cb 1 file changed, 6 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/37230/1

diff --git a/src/mainboard/google/drallion/variants/drallion/devicetree.cb b/src/mainboard/google/drallion/variants/drallion/devicetree.cb index ed44f4f..fa2ec48 100644 --- a/src/mainboard/google/drallion/variants/drallion/devicetree.cb +++ b/src/mainboard/google/drallion/variants/drallion/devicetree.cb @@ -174,20 +174,20 @@ .chipset_lockdown = CHIPSET_LOCKDOWN_COREBOOT, .i2c[0] = { .speed = I2C_SPEED_FAST, - .rise_time_ns = 52, - .fall_time_ns = 110, + .rise_time_ns = 180, + .fall_time_ns = 200, }, .i2c[1] = { .speed = I2C_SPEED_FAST, - .rise_time_ns = 52, - .fall_time_ns = 110, + .rise_time_ns = 30, + .fall_time_ns = 80, .data_hold_time_ns = 330, }, .i2c[4] = { .early_init = 1, .speed = I2C_SPEED_FAST, - .rise_time_ns = 36, - .fall_time_ns = 99, + .rise_time_ns = 30, + .fall_time_ns = 60, }, }"

Attachments:

attachment.htm (text/html — 3.7 KB)

Show replies by date

John Su (Code Review)

28 Nov 28 Nov

1:55 a.m.

John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37230 )

Change subject: mb/google/drallion/variants/drallion: Adjust all I2C CLK to meet spec ......................................................................

Patch Set 2:

This change is ready for review.

-- To view, visit https://review.coreboot.org/c/coreboot/+/37230 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id669d7199bc6ed4b55d7542f095c6c8baf00f984 Gerrit-Change-Number: 37230 Gerrit-PatchSet: 2 Gerrit-Owner: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-CC: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-CC: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-CC: JoeJ Chang joej_chang@compal.corp-partner.google.com Gerrit-Comment-Date: Thu, 28 Nov 2019 01:55:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Chiranjeevi Rapolu (Code Review)

2:27 a.m.

Chiranjeevi Rapolu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37230 )

Change subject: mb/google/drallion/variants/drallion: Adjust all I2C CLK to meet spec ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37230/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/37230/2//COMMIT_MSG@10 PS2, Line 10: Touch Pad CLK: 393 KHz : Touch Screen CLK: 381 KHz : H1 CLK: 391 KHz What were these frequencies before?

-- To view, visit https://review.coreboot.org/c/coreboot/+/37230 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id669d7199bc6ed4b55d7542f095c6c8baf00f984 Gerrit-Change-Number: 37230 Gerrit-PatchSet: 2 Gerrit-Owner: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Chiranjeevi Rapolu chiranjeevi.rapolu@intel.corp-partner.google.com Gerrit-CC: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-CC: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-CC: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-CC: JoeJ Chang joej_chang@compal.corp-partner.google.com Gerrit-Comment-Date: Thu, 28 Nov 2019 02:27:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

John Su (Code Review)

1 Dec 1 Dec

4:21 p.m.

John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37230 )

Change subject: mb/google/drallion/variants/drallion: Adjust all I2C CLK to meet spec ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37230/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/37230/2//COMMIT_MSG@10 PS2, Line 10: Touch Pad CLK: 393 KHz : Touch Screen CLK: 381 KHz : H1 CLK: 391 KHz

...

What were these frequencies before?

H1: 396 KHz Touch Pad: 386 KHz Touch Screen: 364 Khz

What do you think to tune them closer to 400KHz or not ?

-- To view, visit https://review.coreboot.org/c/coreboot/+/37230 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id669d7199bc6ed4b55d7542f095c6c8baf00f984 Gerrit-Change-Number: 37230 Gerrit-PatchSet: 2 Gerrit-Owner: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Chiranjeevi Rapolu chiranjeevi.rapolu@intel.corp-partner.google.com Gerrit-CC: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-CC: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-CC: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-CC: JoeJ Chang joej_chang@compal.corp-partner.google.com Gerrit-Comment-Date: Sun, 01 Dec 2019 16:21:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Chiranjeevi Rapolu chiranjeevi.rapolu@intel.corp-partner.google.com Gerrit-MessageType: comment

Mathew King (Code Review)

2 Dec 2 Dec

9:01 p.m.

Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37230 )

Change subject: mb/google/drallion/variants/drallion: Adjust all I2C CLK to meet spec ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/37230 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id669d7199bc6ed4b55d7542f095c6c8baf00f984 Gerrit-Change-Number: 37230 Gerrit-PatchSet: 2 Gerrit-Owner: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Chiranjeevi Rapolu chiranjeevi.rapolu@intel.corp-partner.google.com Gerrit-CC: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-CC: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-CC: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-CC: JoeJ Chang joej_chang@compal.corp-partner.google.com Gerrit-Comment-Date: Mon, 02 Dec 2019 21:01:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

John Su (Code Review)

4 Dec 4 Dec

3:57 a.m.

John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37230 )

Change subject: mb/google/drallion/variants/drallion: Adjust all I2C CLK to meet spec ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37230/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/37230/2//COMMIT_MSG@10 PS2, Line 10: Touch Pad CLK: 393 KHz : Touch Screen CLK: 381 KHz : H1 CLK: 391 KHz

...

H1: 396 KHz […]

Ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/37230 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id669d7199bc6ed4b55d7542f095c6c8baf00f984 Gerrit-Change-Number: 37230 Gerrit-PatchSet: 2 Gerrit-Owner: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Chiranjeevi Rapolu chiranjeevi.rapolu@intel.corp-partner.google.com Gerrit-CC: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-CC: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-CC: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-CC: JoeJ Chang joej_chang@compal.corp-partner.google.com Gerrit-Comment-Date: Wed, 04 Dec 2019 03:57:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Chiranjeevi Rapolu chiranjeevi.rapolu@intel.corp-partner.google.com Comment-In-Reply-To: John Su john_su@compal.corp-partner.google.com Gerrit-MessageType: comment

Patrick Georgi (Code Review)

2:09 p.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37230 )

Change subject: mb/google/drallion/variants/drallion: Adjust all I2C CLK to meet spec ......................................................................

mb/google/drallion/variants/drallion: Adjust all I2C CLK to meet spec

After adjustment on Drallion Touch Pad CLK: 393 KHz Touch Screen CLK: 381 KHz H1 CLK: 391 KHz

BUG=b:144245601 BRANCH=master TEST=emerge-drallion coreboot chromeos-bootimage measure by scope with drallion.

Change-Id: Id669d7199bc6ed4b55d7542f095c6c8baf00f984 Signed-off-by: John Su john_su@compal.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37230 Reviewed-by: Mathew King mathewk@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/drallion/variants/drallion/devicetree.cb 1 file changed, 6 insertions(+), 6 deletions(-)

Approvals: build bot (Jenkins): Verified Mathew King: Looks good to me, approved

diff --git a/src/mainboard/google/drallion/variants/drallion/devicetree.cb b/src/mainboard/google/drallion/variants/drallion/devicetree.cb index 2fcf191..75fd3ee 100644 --- a/src/mainboard/google/drallion/variants/drallion/devicetree.cb +++ b/src/mainboard/google/drallion/variants/drallion/devicetree.cb @@ -176,20 +176,20 @@ .chipset_lockdown = CHIPSET_LOCKDOWN_COREBOOT, .i2c[0] = { .speed = I2C_SPEED_FAST, - .rise_time_ns = 52, - .fall_time_ns = 110, + .rise_time_ns = 180, + .fall_time_ns = 200, }, .i2c[1] = { .speed = I2C_SPEED_FAST, - .rise_time_ns = 52, - .fall_time_ns = 110, + .rise_time_ns = 30, + .fall_time_ns = 80, .data_hold_time_ns = 330, }, .i2c[4] = { .early_init = 1, .speed = I2C_SPEED_FAST, - .rise_time_ns = 36, - .fall_time_ns = 99, + .rise_time_ns = 30, + .fall_time_ns = 60, }, }"

-- To view, visit https://review.coreboot.org/c/coreboot/+/37230 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id669d7199bc6ed4b55d7542f095c6c8baf00f984 Gerrit-Change-Number: 37230 Gerrit-PatchSet: 3 Gerrit-Owner: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Chiranjeevi Rapolu chiranjeevi.rapolu@intel.corp-partner.google.com Gerrit-CC: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-CC: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-CC: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-CC: JoeJ Chang joej_chang@compal.corp-partner.google.com Gerrit-MessageType: merged

1626

days inactive

1634

days old

coreboot-gerrit@coreboot.org

6 comments

4 participants

tags (0)

participants (4)

Chiranjeevi Rapolu (Code Review)
John Su (Code Review)
Mathew King (Code Review)
Patrick Georgi (Code Review)