Nico Huber has posted comments on this change. ( https://review.coreboot.org/23686 )
Change subject: libpayload/drivers/usb/uhci: Fix regression ......................................................................
Patch Set 1: Code-Review+1
(4 comments)
https://review.coreboot.org/#/c/23686/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/23686/1//COMMIT_MSG@7 PS1, Line 7: libpayload/drivers/usb/uhci: I guess "libpayload/uhci:" would suffice.
https://review.coreboot.org/#/c/23686/1//COMMIT_MSG@7 PS1, Line 7: Fix regression Please mention what it's actually about, e.g. "Return transferred byte count".
https://review.coreboot.org/#/c/23686/1//COMMIT_MSG@10 PS1, Line 10: introduced a regression on I would actually call it what it is, i.e. "deliberately broke". It even says so in the commit message; how the hell could that get merged?
https://review.coreboot.org/#/c/23686/1/payloads/libpayload/drivers/usb/uhci... File payloads/libpayload/drivers/usb/uhci.c:
https://review.coreboot.org/#/c/23686/1/payloads/libpayload/drivers/usb/uhci... PS1, Line 458: return 0; And here?
-
Nico Huber (Code Review)