[S] Change in coreboot[master]: mb/google/dedede/var/dibbi: Generate SPD ID for supported parts Add s...
Liam Flaherty has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/71710 )
Change subject: mb/google/dedede/var/dibbi: Generate SPD ID for supported parts Add supported memory parts in the mem_parts_used.txt and generate the SPD ID for the parts. ......................................................................
mb/google/dedede/var/dibbi: Generate SPD ID for supported parts Add supported memory parts in the mem_parts_used.txt and generate the SPD ID for the parts.
BUG=b:260934724, b:255447299 BRANCH=dedede TEST=build
Change-Id: I8c95ced79e14bb4a99aa1fa5f4fc3bc0681cc1cc Signed-off-by: Liam Flaherty liamflaherty@chromium.org --- M src/mainboard/google/dedede/variants/dibbi/memory/Makefile.inc M src/mainboard/google/dedede/variants/dibbi/memory/dram_id.generated.txt M src/mainboard/google/dedede/variants/dibbi/memory/mem_parts_used.txt 3 files changed, 27 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/71710/1
diff --git a/src/mainboard/google/dedede/variants/dibbi/memory/Makefile.inc b/src/mainboard/google/dedede/variants/dibbi/memory/Makefile.inc index eace2e4..e354c9d 100644 --- a/src/mainboard/google/dedede/variants/dibbi/memory/Makefile.inc +++ b/src/mainboard/google/dedede/variants/dibbi/memory/Makefile.inc @@ -1,5 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-or-later # This is an auto-generated file. Do not edit!! -# Add memory parts in mem_parts_used.txt and run spd_tools to regenerate. +# Generated by: +# ./util/spd_tools/bin/part_id_gen JSL lp4x ./src/mainboard/google/dedede/variants/dibbi/memory ./src/mainboard/google/dedede/variants/dibbi/memory/mem_parts_used.txt
-SPD_SOURCES = placeholder +SPD_SOURCES = +SPD_SOURCES += spd/lp4x/set-1/spd-1.hex # ID = 0(0b0000) Parts = MT53E512M32D1NP-046 WT:B diff --git a/src/mainboard/google/dedede/variants/dibbi/memory/dram_id.generated.txt b/src/mainboard/google/dedede/variants/dibbi/memory/dram_id.generated.txt index fa24790..8f91664 100644 --- a/src/mainboard/google/dedede/variants/dibbi/memory/dram_id.generated.txt +++ b/src/mainboard/google/dedede/variants/dibbi/memory/dram_id.generated.txt @@ -1 +1,7 @@ +# SPDX-License-Identifier: GPL-2.0-or-later +# This is an auto-generated file. Do not edit!! +# Generated by: +# ./util/spd_tools/bin/part_id_gen JSL lp4x ./src/mainboard/google/dedede/variants/dibbi/memory ./src/mainboard/google/dedede/variants/dibbi/memory/mem_parts_used.txt + DRAM Part Name ID to assign +MT53E512M32D1NP-046 WT:B 0 (0000) diff --git a/src/mainboard/google/dedede/variants/dibbi/memory/mem_parts_used.txt b/src/mainboard/google/dedede/variants/dibbi/memory/mem_parts_used.txt index 9621137..5d306f1 100644 --- a/src/mainboard/google/dedede/variants/dibbi/memory/mem_parts_used.txt +++ b/src/mainboard/google/dedede/variants/dibbi/memory/mem_parts_used.txt @@ -1,11 +1 @@ -# This is a CSV file containing a list of memory parts used by this variant. -# One part per line with an optional fixed ID in column 2. -# Only include a fixed ID if it is required for legacy reasons! -# Generated IDs are dependent on the order of parts in this file, -# so new parts must always be added at the end of the file! -# -# Generate an updated Makefile.inc and dram_id.generated.txt by running the -# part_id_gen tool from util/spd_tools. -# See util/spd_tools/README.md for more details and instructions. - -# Part Name +MT53E512M32D1NP-046 WT:B
-
Liam Flaherty (Code Review)