Attention is currently required from: Tim Wawrzynczak, Amanda Hwang, Ivy Jian, Patrick Rudolph, EricR Lai.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51167 )
Change subject: util: Add new memory part for brya boards
......................................................................
Patch Set 1:
(1 comment)
File util/spd_tools/lp4x/global_lp4x_mem_parts.json.txt:
https://review.coreboot.org/c/coreboot/+/51167/comment/dc6e6920_e376b235
PS1, Line 239: 1
D4 means 4 dies per package.
We should be looking at the JEDEC definition for die and not the part vendor definition. https://review.coreboot.org/cgit/coreboot.git/tree/util/spd_tools/lp4x/READM...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51167
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic06e9d672a2d3db2b4ea12d15b462843c90db8f6
Gerrit-Change-Number: 51167
Gerrit-PatchSet: 1
Gerrit-Owner: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-Attention: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Tue, 02 Mar 2021 07:11:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment