Attention is currently required from: Subrata Banik, Angel Pons, Nick Vaccaro, HAOUAS Elyes.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61627 )
Change subject: drivers/pcie/generic: Add new pcie generic chip driver
......................................................................
Patch Set 3:
(3 comments)
File src/drivers/pcie/generic/chip.h:
https://review.coreboot.org/c/coreboot/+/61627/comment/f59fe89d_07a81c3a
PS3, Line 5:
include stdbool. […]
will add <types.h>
File src/drivers/pcie/generic/generic.c:
https://review.coreboot.org/c/coreboot/+/61627/comment/76952002_12edcf51
PS3, Line 20: !config
You also need to update this
Done
https://review.coreboot.org/c/coreboot/+/61627/comment/7c360537_139c329f
PS3, Line 41: pci_rom_ssdt(dev);
This is skipped when `!config->is_untrusted`, is it intentional?
Good catch, will move up
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61627
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I53986614dcbf4d10a6bb4010e131f5ff5a9d25cf
Gerrit-Change-Number: 61627
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Comment-Date: Mon, 07 Feb 2022 15:34:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment