[L] Change in coreboot[main]: mainboard/dell: Add new mainboard XPS 8300 (Sandy Bridge) - coreboot-gerrit

21 Jun 2024


      Attention is currently required from: Elyes Haouas, Paul Menzel, Ronald Claveau.
Felix Singer has posted comments on this change by Ronald Claveau. ( https://review.coreboot.org/c/coreboot/+/83104?usp=email )
Change subject: mainboard/dell: Add new mainboard XPS 8300 (Sandy Bridge)
......................................................................
Patch Set 12:
(1 comment)
File src/mainboard/dell/xps_8300/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/83104/comment/59a9d27d_8412487d?usp... :
PS12, Line 15: //
...
I'd use "#"
That doesn't work here, because it's within the value of `usb_port_config`, which is transformed to C code later. So only C style comments work.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/83104?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7d394794fec580bc7aed3f6396ceb47d4a6fd059
Gerrit-Change-Number: 83104
Gerrit-PatchSet: 12
Gerrit-Owner: Ronald Claveau sousmangoosta@aliel.fr
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Elyes Haouas ehaouas@noos.fr
Gerrit-CC: Felix Singer service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Elyes Haouas ehaouas@noos.fr
Gerrit-Attention: Ronald Claveau sousmangoosta@aliel.fr
Gerrit-Comment-Date: Fri, 21 Jun 2024 18:00:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Elyes Haouas ehaouas@noos.fr