Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Rishika Raj, Shon Wang, Subrata Banik.
Derek Huang has posted comments on this change by Shon Wang. ( https://review.coreboot.org/c/coreboot/+/83593?usp=email )
Change subject: mb/google/brask/var/bujia: Add PsysPmax setting
......................................................................
Patch Set 8:
(4 comments)
File src/mainboard/google/brya/variants/bujia/include/variant/get_input_power_voltage.h:
https://review.coreboot.org/c/coreboot/+/83593/comment/2d435978_96abcfa8?usp... :
PS8, Line 1: /* SPDX-License-Identifier: GPL-2.0-or-later */
:
: #ifndef VARIANT_GET_INPUT_POWER_VOLTAGE_H
: #define VARIANT_GET_INPUT_POWER_VOLTAGE_H
:
: int32_t get_input_power_voltage(void);
:
: #endif
:
This file is redundant.
File src/mainboard/google/brya/variants/bujia/ramstage.c:
https://review.coreboot.org/c/coreboot/+/83593/comment/85d46d46_379b4858?usp... :
PS8, Line 10: #include <fw_config.h>
redundant
https://review.coreboot.org/c/coreboot/+/83593/comment/56f981e8_787218cc?usp... :
PS8, Line 12: #include <variant/get_input_power_voltage.h>
redundant
https://review.coreboot.org/c/coreboot/+/83593/comment/3022645d_163a2680?usp... :
PS8, Line 64: int32_t
static int32_t
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83593?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic6e9c6ce9f3179c7d63c1169695fbc23188456dd
Gerrit-Change-Number: 83593
Gerrit-PatchSet: 8
Gerrit-Owner: Shon Wang
shon.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Rishika Raj
rishikaraj@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Rishika Raj
rishikaraj@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Shon Wang
shon.wang@quanta.corp-partner.google.com
Gerrit-Comment-Date: Mon, 02 Sep 2024 01:04:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No