Attention is currently required from: Felix Singer, Lance Zhao, Jason Glenesk, Raul Rangel, Nico Huber, Furquan Shaikh, Marshall Dawson, Tim Wawrzynczak, Angel Pons, Patrick Rudolph, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58118 )
Change subject: acpigen,soc/amd/cezanne,intel/{common,skl}: rework CPPC table passing ......................................................................
Patch Set 8:
(10 comments)
File src/soc/amd/cezanne/cppc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130138): https://review.coreboot.org/c/coreboot/+/58118/comment/ef1ff955_f037b730 PS8, Line 15: [CPPC_HIGHEST_PERF] = CPPC_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_HIGHEST_PERF, 8), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130138): https://review.coreboot.org/c/coreboot/+/58118/comment/01906c14_0d3242fc PS8, Line 16: [CPPC_NOMINAL_PERF] = CPPC_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_NOMINAL_PERF, 8), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130138): https://review.coreboot.org/c/coreboot/+/58118/comment/1ee333ab_4962b473 PS8, Line 17: [CPPC_LOWEST_NONL_PERF] = CPPC_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_LOW_NON_LIN_PERF, 8), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130138): https://review.coreboot.org/c/coreboot/+/58118/comment/8999195c_21c47942 PS8, Line 18: [CPPC_LOWEST_PERF] = CPPC_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_LOWEST_PERF, 8), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130138): https://review.coreboot.org/c/coreboot/+/58118/comment/350164b4_95b4e807 PS8, Line 20: [CPPC_DESIRED_PERF] = CPPC_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_DES_PERF, 8), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130138): https://review.coreboot.org/c/coreboot/+/58118/comment/e298b8b2_43916d64 PS8, Line 21: [CPPC_MIN_PERF] = CPPC_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_MIN_PERF, 8), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130138): https://review.coreboot.org/c/coreboot/+/58118/comment/fc6f1320_287dfeb2 PS8, Line 22: [CPPC_MAX_PERF] = CPPC_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_MAX_PERF, 8), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130138): https://review.coreboot.org/c/coreboot/+/58118/comment/5eddd3e5_28ffb09c PS8, Line 26: [CPPC_REF_PERF_COUNTER] = CPPC_REG_MSR(MSR_MAX_PERFORMANCE_FREQUENCY_CLOCK_COUNT, 0, 64), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130138): https://review.coreboot.org/c/coreboot/+/58118/comment/94405c13_29ce9ae3 PS8, Line 27: [CPPC_DELIVERED_PERF_COUNTER] = CPPC_REG_MSR(MSR_ACTUAL_PERFORMANCE_FREQUENCY_CLOCK_COUNT, 0, 64), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130138): https://review.coreboot.org/c/coreboot/+/58118/comment/afa126b4_c46c0caf PS8, Line 34: [CPPC_PERF_PREF] = CPPC_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_ENERGY_PERF_PREF, 8), line over 96 characters