Attention is currently required from: David Wu, Ren Kuo, Shelley Chen, Subrata Banik, Tyler Wang.
Karthik Ramasubramanian has posted comments on this change by Ren Kuo. ( https://review.coreboot.org/c/coreboot/+/83212?usp=email )
Change subject: mb/google/brox: Create jubilant variant
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/brox/variants/jubilant/gpio.c:
https://review.coreboot.org/c/coreboot/+/83212/comment/deed9f59_2b7ecf08?usp... :
PS4, Line 227:
Nit: Remove all the empty newlines at the end of the file. Checkpatch is raising an error. Here and in other files.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83212?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic54437697058f8bce2167093bd88c0880d1b7cac
Gerrit-Change-Number: 83212
Gerrit-PatchSet: 4
Gerrit-Owner: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Attention: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Comment-Date: Fri, 26 Jul 2024 17:05:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No