Attention is currently required from: Jérémy Compostella, Shuo Liu, yuchi.chen@intel.com.
Elyes Haouas has posted comments on this change by yuchi.chen@intel.com. ( https://review.coreboot.org/c/coreboot/+/83322?usp=email )
Change subject: src/mainboard/intel/frost_creek: add a new CRB Frost Creek for SNR
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/intel/frost_creek/acpi/platform.asl:
https://review.coreboot.org/c/coreboot/+/83322/comment/8d9e150d_d74b8f3e?usp... :
PS3, Line 22: Store (Arg0, SMIF) // SMI Function
: Store (0,
Please use ASL2 syntax
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83322?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If3b387a6a4a567415aef21e520056c23b8cfa013
Gerrit-Change-Number: 83322
Gerrit-PatchSet: 3
Gerrit-Owner: yuchi.chen@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-Attention: yuchi.chen@intel.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Comment-Date: Wed, 03 Jul 2024 05:54:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No