Wim Vervoorn has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36097 )
Change subject: mb/facebook/fbg1701: move all logo support to logo.h ......................................................................
mb/facebook/fbg1701: move all logo support to logo.h
Move all items related to the logo to logo.h and remove mainboard.h.
BUG=N/A TEST=tested on fbg1701
Change-Id: I921ae914c13d93057d5498d8262db2c455b97eaf Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- M src/mainboard/facebook/fbg1701/logo.c R src/mainboard/facebook/fbg1701/logo.h M src/mainboard/facebook/fbg1701/ramstage.c 3 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/36097/1
diff --git a/src/mainboard/facebook/fbg1701/logo.c b/src/mainboard/facebook/fbg1701/logo.c index 10c72c7..3823c71 100644 --- a/src/mainboard/facebook/fbg1701/logo.c +++ b/src/mainboard/facebook/fbg1701/logo.c @@ -17,7 +17,7 @@ #include <soc/ramstage.h> #include <console/console.h> #include <include/cbfs.h> -#include "mainboard.h" +#include "logo.h"
static char logo_data[1 * MiB]; static size_t logo_data_sz = 0; diff --git a/src/mainboard/facebook/fbg1701/mainboard.h b/src/mainboard/facebook/fbg1701/logo.h similarity index 87% rename from src/mainboard/facebook/fbg1701/mainboard.h rename to src/mainboard/facebook/fbg1701/logo.h index 82f1b99..0682d3fa 100644 --- a/src/mainboard/facebook/fbg1701/mainboard.h +++ b/src/mainboard/facebook/fbg1701/logo.h @@ -1,7 +1,7 @@ /* * This file is part of the coreboot project. * - * Copyright (C) 2018-2019 Eltan B.V. + * Copyright (C) 2019 Eltan B.V. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -13,8 +13,8 @@ * GNU General Public License for more details. */
-#ifndef MAINBOARD_H -#define MAINBOARD_H +#ifndef LOGO_H +#define LOGO_H
void *load_logo(size_t *logo_size);
diff --git a/src/mainboard/facebook/fbg1701/ramstage.c b/src/mainboard/facebook/fbg1701/ramstage.c index e2b4ac3..9b25b983 100644 --- a/src/mainboard/facebook/fbg1701/ramstage.c +++ b/src/mainboard/facebook/fbg1701/ramstage.c @@ -18,8 +18,8 @@ #include <console/console.h> #include <soc/ramstage.h> #include <soc/smbus.h> -#include "mainboard.h" #include "cpld.h" +#include "logo.h"
struct edp_data { u8 payload_length;
Hello Frans Hendriks,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36097
to look at the new patch set (#2).
Change subject: mb/facebook/fbg1701: rename mainboard.h to logo.h ......................................................................
mb/facebook/fbg1701: rename mainboard.h to logo.h
Renamed mainboard.h to logo.h as it only contains logo related items.
BUG=N/A TEST=tested on fbg1701
Change-Id: I921ae914c13d93057d5498d8262db2c455b97eaf Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- M src/mainboard/facebook/fbg1701/logo.c R src/mainboard/facebook/fbg1701/logo.h M src/mainboard/facebook/fbg1701/ramstage.c 3 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/36097/2
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36097 )
Change subject: mb/facebook/fbg1701: rename mainboard.h to logo.h ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36097 )
Change subject: mb/facebook/fbg1701: rename mainboard.h to logo.h ......................................................................
mb/facebook/fbg1701: rename mainboard.h to logo.h
Renamed mainboard.h to logo.h as it only contains logo related items.
BUG=N/A TEST=tested on fbg1701
Change-Id: I921ae914c13d93057d5498d8262db2c455b97eaf Signed-off-by: Wim Vervoorn wvervoorn@eltan.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/36097 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Frans Hendriks fhendriks@eltan.com --- M src/mainboard/facebook/fbg1701/logo.c R src/mainboard/facebook/fbg1701/logo.h M src/mainboard/facebook/fbg1701/ramstage.c 3 files changed, 5 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Frans Hendriks: Looks good to me, approved
diff --git a/src/mainboard/facebook/fbg1701/logo.c b/src/mainboard/facebook/fbg1701/logo.c index 10c72c7..3823c71 100644 --- a/src/mainboard/facebook/fbg1701/logo.c +++ b/src/mainboard/facebook/fbg1701/logo.c @@ -17,7 +17,7 @@ #include <soc/ramstage.h> #include <console/console.h> #include <include/cbfs.h> -#include "mainboard.h" +#include "logo.h"
static char logo_data[1 * MiB]; static size_t logo_data_sz = 0; diff --git a/src/mainboard/facebook/fbg1701/mainboard.h b/src/mainboard/facebook/fbg1701/logo.h similarity index 87% rename from src/mainboard/facebook/fbg1701/mainboard.h rename to src/mainboard/facebook/fbg1701/logo.h index 82f1b99..0682d3fa 100644 --- a/src/mainboard/facebook/fbg1701/mainboard.h +++ b/src/mainboard/facebook/fbg1701/logo.h @@ -1,7 +1,7 @@ /* * This file is part of the coreboot project. * - * Copyright (C) 2018-2019 Eltan B.V. + * Copyright (C) 2019 Eltan B.V. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -13,8 +13,8 @@ * GNU General Public License for more details. */
-#ifndef MAINBOARD_H -#define MAINBOARD_H +#ifndef LOGO_H +#define LOGO_H
void *load_logo(size_t *logo_size);
diff --git a/src/mainboard/facebook/fbg1701/ramstage.c b/src/mainboard/facebook/fbg1701/ramstage.c index e2b4ac3..9b25b983 100644 --- a/src/mainboard/facebook/fbg1701/ramstage.c +++ b/src/mainboard/facebook/fbg1701/ramstage.c @@ -18,8 +18,8 @@ #include <console/console.h> #include <soc/ramstage.h> #include <soc/smbus.h> -#include "mainboard.h" #include "cpld.h" +#include "logo.h"
struct edp_data { u8 payload_length;
-
Frans Hendriks (Code Review) -
Patrick Georgi (Code Review)
-
Wim Vervoorn (Code Review)