Attention is currently required from: Anjaneya "Reddy" Chagam, Johnny Lin, Christian Walter, Shuming Chu (Shuming), Arthur Heymans.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68567 )
Change subject: soc/intel/xeon_sp: Add functions to store/restore uart state in smm
......................................................................
Patch Set 4:
(2 comments)
File src/soc/intel/xeon_sp/smihandler.c:
https://review.coreboot.org/c/coreboot/+/68567/comment/f38aed9e_f555cd2c
PS4, Line 32: if (CONFIG(DEBUG_SMI))
This should also depend on `DRIVERS_UART_8250IO`:
if (CONFIG(DRIVERS_UART_8250IO) && CONFIG(DEBUG_SMI))
https://review.coreboot.org/c/coreboot/+/68567/comment/a5e42aad_37749b6d
PS4, Line 49: if (CONFIG(DEBUG_SMI))
This should also depend on `DRIVERS_UART_8250IO`:
if (CONFIG(DRIVERS_UART_8250IO) && CONFIG(DEBUG_SMI))
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68567
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifa5042c24f0e3217a75971d9e6067b1d1f56a484
Gerrit-Change-Number: 68567
Gerrit-PatchSet: 4
Gerrit-Owner: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Attention: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 21 Oct 2022 17:55:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment