Nico Huber has posted comments on this change. ( https://review.coreboot.org/27801 )
Change subject: cpu/x86/lapic/apic_timer.c: Compile the same code for all stages ......................................................................
Patch Set 2: Code-Review+1
(3 comments)
https://review.coreboot.org/#/c/27801/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/27801/2//COMMIT_MSG@9 PS2, Line 9: line is too long, break here
https://review.coreboot.org/#/c/27801/1/src/cpu/x86/lapic/apic_timer.c File src/cpu/x86/lapic/apic_timer.c:
https://review.coreboot.org/#/c/27801/1/src/cpu/x86/lapic/apic_timer.c@156 PS1, Line 156: don't we need `car_get_var_ptr()` here?
... ok, you were faster :-P
https://review.coreboot.org/#/c/27801/2/src/cpu/x86/lapic/apic_timer.c File src/cpu/x86/lapic/apic_timer.c:
https://review.coreboot.org/#/c/27801/2/src/cpu/x86/lapic/apic_timer.c@150 PS2, Line 150: static inline struct monotonic_counter *get_monotonic_context(void) Having a single-line function for a single invocation seems overkill.