Change in coreboot[master]: vc/amd/fsp/picasso: add comment on logical lane numbers in descriptor
Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43311 )
Change subject: vc/amd/fsp/picasso: add comment on logical lane numbers in descriptor ......................................................................
vc/amd/fsp/picasso: add comment on logical lane numbers in descriptor
The expected lane numbers in the fsp_pcie_descriptor struct are the logical and not the physical ones.
Change-Id: I14166bbd397a9e5f5c5370717e039b9e71cbdb07 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/vendorcode/amd/fsp/picasso/platform_descriptors.h 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/43311/1
diff --git a/src/vendorcode/amd/fsp/picasso/platform_descriptors.h b/src/vendorcode/amd/fsp/picasso/platform_descriptors.h index cae5d45..20c7c65 100644 --- a/src/vendorcode/amd/fsp/picasso/platform_descriptors.h +++ b/src/vendorcode/amd/fsp/picasso/platform_descriptors.h @@ -110,6 +110,7 @@ } fsp_ddi_descriptor;
/* Picasso PCIe Descriptor: used for assigning lanes, bifurcation and other settings */ +/* Beware that the lane numbers in there are the logical and not the physical lane numbers! */ typedef struct __packed { uint8_t engine_type; uint8_t start_lane; // Start lane of the pci device
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43311 )
Change subject: vc/amd/fsp/picasso: add comment on logical lane numbers in descriptor ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/43311/1/src/vendorcode/amd/fsp/pica... File src/vendorcode/amd/fsp/picasso/platform_descriptors.h:
https://review.coreboot.org/c/coreboot/+/43311/1/src/vendorcode/amd/fsp/pica... PS1, Line 113: there here?
Hello Jason Glenesk, Raul Rangel, Furquan Shaikh, Matt Papageorge,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43311
to look at the new patch set (#2).
Change subject: vc/amd/fsp/picasso: add comment on logical lane numbers in descriptor ......................................................................
vc/amd/fsp/picasso: add comment on logical lane numbers in descriptor
The expected lane numbers in the fsp_pcie_descriptor struct are the logical and not the physical ones.
Change-Id: I14166bbd397a9e5f5c5370717e039b9e71cbdb07 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/vendorcode/amd/fsp/picasso/platform_descriptors.h 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/43311/2
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43311 )
Change subject: vc/amd/fsp/picasso: add comment on logical lane numbers in descriptor ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43311/1/src/vendorcode/amd/fsp/pica... File src/vendorcode/amd/fsp/picasso/platform_descriptors.h:
https://review.coreboot.org/c/coreboot/+/43311/1/src/vendorcode/amd/fsp/pica... PS1, Line 113: there
here?
yep, that's better
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43311 )
Change subject: vc/amd/fsp/picasso: add comment on logical lane numbers in descriptor ......................................................................
Patch Set 2: Code-Review+2
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43311 )
Change subject: vc/amd/fsp/picasso: add comment on logical lane numbers in descriptor ......................................................................
Patch Set 2: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43311 )
Change subject: vc/amd/fsp/picasso: add comment on logical lane numbers in descriptor ......................................................................
vc/amd/fsp/picasso: add comment on logical lane numbers in descriptor
The expected lane numbers in the fsp_pcie_descriptor struct are the logical and not the physical ones.
Change-Id: I14166bbd397a9e5f5c5370717e039b9e71cbdb07 Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/43311 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Raul Rangel rrangel@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/vendorcode/amd/fsp/picasso/platform_descriptors.h 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Raul Rangel: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/vendorcode/amd/fsp/picasso/platform_descriptors.h b/src/vendorcode/amd/fsp/picasso/platform_descriptors.h index cae5d45..9765ea6 100644 --- a/src/vendorcode/amd/fsp/picasso/platform_descriptors.h +++ b/src/vendorcode/amd/fsp/picasso/platform_descriptors.h @@ -110,6 +110,7 @@ } fsp_ddi_descriptor;
/* Picasso PCIe Descriptor: used for assigning lanes, bifurcation and other settings */ +/* Beware that the lane numbers in here are the logical and not the physical lane numbers! */ typedef struct __packed { uint8_t engine_type; uint8_t start_lane; // Start lane of the pci device
-
Angel Pons (Code Review) -
Felix Held (Code Review)
-
Raul Rangel (Code Review)