Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31713 )
Change subject: drivers/intel/fsp1_0: Deduplicate code
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31713/1/src/drivers/intel/fsp1_0/fsp_util.c
File src/drivers/intel/fsp1_0/fsp_util.c:
https://review.coreboot.org/#/c/31713/1/src/drivers/intel/fsp1_0/fsp_util.c@...
PS1, Line 109: oid ChipsetFspReturnPoint(EFI_STATUS Status, VOID *HobListPtr)
Once there is no external caller more for this function should we make it static and remove it from fsp_util.h completely? We even can rename it to something like fsp_return_point() or the like since it is not more specific for a given chipset but is more a common function for fsp1.0.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31713
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I064ae67041c521ee92877cff30c814fce7b08e1f
Gerrit-Change-Number: 31713
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Jay Talbott
JayTalbott@sysproconsulting.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: York Yang
york.yang@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 05 Mar 2019 05:47:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment