Change in ...coreboot[master]: mb/google/hatch: Reconfigure SD card detect GPIO host software ownership

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Krishna P Bhat D (Code Review)

31 Jan 2019 31 Jan '19

10:23 a.m.

Krishna P Bhat D has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31178

Change subject: mb/google/hatch: Reconfigure SD card detect GPIO host software ownership ......................................................................

mb/google/hatch: Reconfigure SD card detect GPIO host software ownership

This implementation reconfigures SD card detect GPIO(GPP_G5) host ownership to GPIO driver mode.

BUG=b:123432607 BRANCH=None TEST=Check SD card gets detected and data transfer working.

Change-Id: Id214184f3e183f6feb6887484cd4ccd3bab65b1a Signed-off-by: Krishna Prasad Bhat krishna.p.bhat.d@intel.com --- M src/mainboard/google/hatch/variants/baseboard/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/31178/1

diff --git a/src/mainboard/google/hatch/variants/baseboard/gpio.c b/src/mainboard/google/hatch/variants/baseboard/gpio.c index a078997..4b923829 100644 --- a/src/mainboard/google/hatch/variants/baseboard/gpio.c +++ b/src/mainboard/google/hatch/variants/baseboard/gpio.c @@ -138,7 +138,7 @@ /* SD_DATA3 */ PAD_CFG_NF(GPP_G4, NONE, DEEP, NF1), /* SD_CD# */ - PAD_CFG_NF(GPP_G5, NONE, DEEP, NF1), + PAD_CFG_GPI_GPIO_DRIVER(GPP_G5, NONE, DEEP), /* SD_CLK */ PAD_CFG_NF(GPP_G6, NONE, DEEP, NF1), /* SD_WP => NC */

Attachments:

attachment.htm (text/html — 2.7 KB)

Show replies by date

Subrata Banik (Code Review)

1 Feb 1 Feb

1:30 a.m.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31178 )

Change subject: mb/google/hatch: Reconfigure SD card detect GPIO host software ownership ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/31178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id214184f3e183f6feb6887484cd4ccd3bab65b1a Gerrit-Change-Number: 31178 Gerrit-PatchSet: 1 Gerrit-Owner: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Rajat Jain rajatja@google.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 01 Feb 2019 04:30:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

3:33 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31178 )

Change subject: mb/google/hatch: Reconfigure SD card detect GPIO host software ownership ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/31178/1/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/31178/1/src/mainboard/google/hatch/variants/... PS1, Line 141: PAD_CFG_GPI_GPIO_DRIVER Does it not result in any issues if CD# is not configured as native function for the SD controller?

-- To view, visit https://review.coreboot.org/c/coreboot/+/31178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id214184f3e183f6feb6887484cd4ccd3bab65b1a Gerrit-Change-Number: 31178 Gerrit-PatchSet: 1 Gerrit-Owner: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Rajat Jain rajatja@google.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 01 Feb 2019 18:33:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

3 Feb 3 Feb

4:34 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31178 )

Change subject: mb/google/hatch: Reconfigure SD card detect GPIO host software ownership ......................................................................

Patch Set 1: Code-Review-1

-- To view, visit https://review.coreboot.org/c/coreboot/+/31178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id214184f3e183f6feb6887484cd4ccd3bab65b1a Gerrit-Change-Number: 31178 Gerrit-PatchSet: 1 Gerrit-Owner: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Rajat Jain rajatja@google.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 03 Feb 2019 19:34:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

4:35 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31178 )

Change subject: mb/google/hatch: Reconfigure SD card detect GPIO host software ownership ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/31178/1/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/31178/1/src/mainboard/google/hatch/variants/... PS1, Line 141: PAD_CFG_GPI_GPIO_DRIVER

...

Does it not result in any issues if CD# is not configured as native function for the SD controller?

I want to understand this better before the change gets pushed in. Why does this pin have to be configured in GPIO mode? Wouldn't the SD controller want it to be in native mode?

-- To view, visit https://review.coreboot.org/c/coreboot/+/31178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id214184f3e183f6feb6887484cd4ccd3bab65b1a Gerrit-Change-Number: 31178 Gerrit-PatchSet: 1 Gerrit-Owner: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Rajat Jain rajatja@google.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 03 Feb 2019 19:35:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Rizwan Qureshi (Code Review)

4 Feb 4 Feb

3:47 a.m.

Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31178 )

Change subject: mb/google/hatch: Reconfigure SD card detect GPIO host software ownership ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/31178/1/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/31178/1/src/mainboard/google/hatch/variants/... PS1, Line 141: PAD_CFG_GPI_GPIO_DRIVER

...

I want to understand this better before the change gets pushed in. […]

this was done at the whim of the kernel driver. If this is set to native, the pinctrlr driver in kernel could not cofigure IRQ for this pin, "INT34BB:00: pin 56 cannot be used as IRQ", changing the host SW ownership to driver will fix this issue.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id214184f3e183f6feb6887484cd4ccd3bab65b1a Gerrit-Change-Number: 31178 Gerrit-PatchSet: 1 Gerrit-Owner: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Rajat Jain rajatja@google.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 04 Feb 2019 06:47:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

3:50 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31178 )

Change subject: mb/google/hatch: Reconfigure SD card detect GPIO host software ownership ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/31178/1/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/31178/1/src/mainboard/google/hatch/variants/... PS1, Line 141: PAD_CFG_GPI_GPIO_DRIVER

...

this was done at the whim of the kernel driver. […]

This brings up two questions to mind: 1. What is the impact of doing this on the SD controller? Wouldn't it want the pin to be in native mode?

2. Since the kernel driver wants to configure this in a certain way, would it make sense to dual-route this signal?

-- To view, visit https://review.coreboot.org/c/coreboot/+/31178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id214184f3e183f6feb6887484cd4ccd3bab65b1a Gerrit-Change-Number: 31178 Gerrit-PatchSet: 1 Gerrit-Owner: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Rajat Jain rajatja@google.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 04 Feb 2019 06:50:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Rizwan Qureshi rizwan.qureshi@intel.com Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Rizwan Qureshi (Code Review)

4:21 a.m.

Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31178 )

Change subject: mb/google/hatch: Reconfigure SD card detect GPIO host software ownership ......................................................................

Patch Set 1:

(1 comment)

...

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/31178/1/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/31178/1/src/mainboard/google/hatch/variants/... PS1, Line 141: PAD_CFG_GPI_GPIO_DRIVER

...

What is the impact of doing this on the SD controller? Wouldn't it want the pin to be in native mode?

We are checking this.

...

Since the kernel driver wants to configure this in a certain way, would it make sense to dual-route this signal?

Or, does the kernel really need to program this pin for IRQ?

-- To view, visit https://review.coreboot.org/c/coreboot/+/31178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id214184f3e183f6feb6887484cd4ccd3bab65b1a Gerrit-Change-Number: 31178 Gerrit-PatchSet: 1 Gerrit-Owner: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Rajat Jain rajatja@google.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 04 Feb 2019 07:21:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Rizwan Qureshi rizwan.qureshi@intel.com Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

4:42 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31178 )

Change subject: mb/google/hatch: Reconfigure SD card detect GPIO host software ownership ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/31178/1/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/31178/1/src/mainboard/google/hatch/variants/... PS1, Line 141: PAD_CFG_GPI_GPIO_DRIVER

...

...

Since the kernel driver wants to configure this in a certain way, would it make sense to dual-route this signal?

Or, does the kernel really need to program this pin for IRQ?

I believe the kernel needs it to enable/disable wake from SD card insert. I will have to go back and check the kernel driver to see its use. Rajat might be able to provide more input on this.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id214184f3e183f6feb6887484cd4ccd3bab65b1a Gerrit-Change-Number: 31178 Gerrit-PatchSet: 1 Gerrit-Owner: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Rajat Jain rajatja@google.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 04 Feb 2019 07:42:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Rizwan Qureshi rizwan.qureshi@intel.com Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Ronak Kanabar (Code Review)

5:08 a.m.

Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31178 )

Change subject: mb/google/hatch: Reconfigure SD card detect GPIO host software ownership ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/31178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id214184f3e183f6feb6887484cd4ccd3bab65b1a Gerrit-Change-Number: 31178 Gerrit-PatchSet: 1 Gerrit-Owner: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Rajat Jain rajatja@google.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Ronak Kanabar ronak.kanabar@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 04 Feb 2019 08:08:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Rajat Jain (Code Review)

8:07 p.m.

Rajat Jain has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31178 )

Change subject: mb/google/hatch: Reconfigure SD card detect GPIO host software ownership ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/31178/1/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/31178/1/src/mainboard/google/hatch/variants/... PS1, Line 141: PAD_CFG_GPI_GPIO_DRIVER

...

...
...

[…]

Lets move this discussion to the bug. I am putting my comments there.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id214184f3e183f6feb6887484cd4ccd3bab65b1a Gerrit-Change-Number: 31178 Gerrit-PatchSet: 1 Gerrit-Owner: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Rajat Jain rajatja@google.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Ronak Kanabar ronak.kanabar@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 04 Feb 2019 23:07:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Rizwan Qureshi rizwan.qureshi@intel.com Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Paul Menzel (Code Review)

5 Feb 5 Feb

9:52 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31178 )

Change subject: mb/google/hatch: Reconfigure SD card detect GPIO host software ownership ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/31178/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/31178/1//COMMIT_MSG@9 PS1, Line 9: GPIO(GPP_G5) Please add a space before the (.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id214184f3e183f6feb6887484cd4ccd3bab65b1a Gerrit-Change-Number: 31178 Gerrit-PatchSet: 1 Gerrit-Owner: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Rajat Jain rajatja@google.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Ronak Kanabar ronak.kanabar@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 05 Feb 2019 12:52:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Krishna P Bhat D (Code Review)

6 Feb 6 Feb

9:14 a.m.

Hello Rajat Jain, Subrata Banik, Ronak Kanabar, Aamir Bohra, Rizwan Qureshi, Shelley Chen, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31178

to look at the new patch set (#2).

Change subject: mb/google/hatch: Reconfigure SD card detect GPIO host software ownership ......................................................................

mb/google/hatch: Reconfigure SD card detect GPIO host software ownership

This implementation reconfigures SD card detect GPIO (GPP_G5) host ownership to GPIO driver mode.

BUG=b:123432607 BRANCH=None TEST=Check SD card gets detected and data transfer working.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/31178/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/31178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id214184f3e183f6feb6887484cd4ccd3bab65b1a Gerrit-Change-Number: 31178 Gerrit-PatchSet: 2 Gerrit-Owner: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Rajat Jain rajatja@google.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Ronak Kanabar ronak.kanabar@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Krishna P Bhat D (Code Review)

9:15 a.m.

Krishna P Bhat D has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31178 )

Change subject: mb/google/hatch: Reconfigure SD card detect GPIO host software ownership ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/31178/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/31178/1//COMMIT_MSG@9 PS1, Line 9: GPIO(GPP_G5)

...

Please add a space before the (.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/31178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id214184f3e183f6feb6887484cd4ccd3bab65b1a Gerrit-Change-Number: 31178 Gerrit-PatchSet: 2 Gerrit-Owner: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Rajat Jain rajatja@google.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Ronak Kanabar ronak.kanabar@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 06 Feb 2019 12:15:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Ronak Kanabar (Code Review)

20 Feb 20 Feb

6:54 a.m.

Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31178 )

Change subject: mb/google/hatch: Reconfigure SD card detect GPIO host software ownership ......................................................................

Patch Set 2: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/31178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id214184f3e183f6feb6887484cd4ccd3bab65b1a Gerrit-Change-Number: 31178 Gerrit-PatchSet: 2 Gerrit-Owner: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Rajat Jain rajatja@google.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Ronak Kanabar ronak.kanabar@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 20 Feb 2019 09:54:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Krishna P Bhat D (Code Review)

18 Mar 18 Mar

2:30 a.m.

Krishna P Bhat D has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/31178 )

Change subject: mb/google/hatch: Reconfigure SD card detect GPIO host software ownership ......................................................................

Abandoned

-- To view, visit https://review.coreboot.org/c/coreboot/+/31178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id214184f3e183f6feb6887484cd4ccd3bab65b1a Gerrit-Change-Number: 31178 Gerrit-PatchSet: 2 Gerrit-Owner: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Rajat Jain rajatja@google.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Ronak Kanabar ronak.kanabar@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: abandon

1919

days inactive

1965

days old

coreboot-gerrit@coreboot.org

15 comments

7 participants

tags (0)

participants (7)

Furquan Shaikh (Code Review)
Krishna P Bhat D (Code Review)
Paul Menzel (Code Review)
Rajat Jain (Code Review)
Rizwan Qureshi (Code Review)
Ronak Kanabar (Code Review)
Subrata Banik (Code Review)